Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Gradle check job fails to publish metrics when pr_number is null. #4708

Closed
prudhvigodithi opened this issue May 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@prudhvigodithi
Copy link
Collaborator

Describe the bug

Coming from a failed gradle check job https://build.ci.opensearch.org/job/gradle-check/38585/console with error No such property: pr_number for class: groovy.lang.Binding, this error occurs because the job was triggered by parameterizedCron, this could even happen when the job was involved manually.

To reproduce

Rebuilding the job https://build.ci.opensearch.org/job/gradle-check/38585/console should throw the same error again

Expected behavior

The publishGradleCheckTestResults.groovy that publishes the metrics should get proper inputs of pr_number. For this, the gradle check job should handle when triggered by PR use the pr_number, by User or by Timer then fallback to GIT_REFERENCE. The library publishGradleCheckTestResults should also be publish the metrics with new field invoke_type where the metrics can be filtered properly by User, Timer, Post Merge Action and Pull Request.

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

@prudhvigodithi
Copy link
Collaborator Author

Closing this as the Gradle check job does not fail now with null pr_number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants