-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] Release version 2.17.1 #5046
Comments
We have recently found an issue related to OSD, due to the Chrome browser update: The issue seems coming from chrome itself, with an issue opened in here: A temp workaround in OSD core has been sent as well: We want to analyze the situation and see if it grants a potential patch release such as 2.17.1.
cc: @Pallavi-AWS @dblock @anirudha @ashwin-pc @AMoo-Miki @getsaurabh02 Thanks. |
Thanks @peterzhuamazon for adding details. @ashwin-pc Can we also add if there is any workaround from the Chrome side, which users can do and we can share in form of documentation?
|
Thanks for opening the issue @peterzhuamazon @getsaurabh02. To answer your questions:
its started in version 129 and still exists in the latest 130 version
Users can use an alternate browser Both Edge and Safari dont seem to have this bug. That being said, many of the other browsers are built on top of Chromium, so its very likely that they will also have this bug when they update to use the latest version of Chrome.
Discover is unusable since the results table is covered by a red mask
The work arounds suggested here expect the user to change the CSS on their page using the developer tools panel. Using an alternate browser is an easier workaround though and the suggestions in the issue were most for the code fix we needed to make. |
Thanks @ashwin-pc. One last thing since user here mentioned the below workaround irrespective of the CSS update. Is it not working?
Adding maintainers for any feedback/concerns @AMoo-Miki @dbbaughe @msfroh |
The user there was calling out that the issue for them was not always reproducible, but their fix/workaround does always work. The issue for me and @AMoo-Miki however was always reproducible. |
Thanks, @ashwin-pc. I will allow today for any final feedback or concerns from the maintainers. If none are raised, we will start the code freeze tomorrow and proceed to release as soon as the final RC is ready. The release window is typically one week, so we expect to have the final RC ready for release by Tuesday, October 1st. Please ensure that no other commits (aside from those discussed on this thread) are included in this patch release. Any other changes on the 2.17 branch, apart from those tagged in the patch issue, will be reverted. Tagging @Divyaasm and @peterzhuamazon for support on this release. We will begin the announcement on the public slack. |
@ashwin-pc. Few more questions, while we prep for the patch release in parallel:
Can we please confirm this, since it will determine the urgency/need of the fix and patch release.
Is there any eta on the issue being tracked from the Chrome side? Is it okay to ask user to use other versions of Chrome of other browser, since this issue anyways affects all versions of OSD. |
Yes we have confirmed the issue is always reproducable and we have even submitted the exact reproduction steps to the chrome team which they were also able to reproduce it on their end
They havent provided me any ETA yet on the issue. They have acknowledged the issue though. Asking users to use another browser is a valid workaround but given that al major browsers besides Firefox and Safari are built on top of Chrome, this issue will grow in size even if it is patched in Chrome. I dont think we should rely on the browser fix alone to mitigate this issue. |
@getsaurabh02, according to Chrome's issue tracking system, the bug we reported is marked as a P1 with an S2 level, and is slated for the 131 release. If the fix makes it into their 131 release, it is expected to be available on November 12, 2024. However, if the Chrome team misses the 131 release window, their next opportunity to address the issue will be with the 132 release on January 7, 2025. In the best-case scenario, we are anticipating a minimum of another 50 days before Chrome users will see a resolution to this bug. The next best scenario would involve a wait of 106 days. |
opensearch-project/security-analytics#1319 Cc: @getsaurabh02 |
@eirsep is threat intelligence a new feature and under feature flag? Why these cannot wait until until 2.18 given this was not called out yet? Can you elaborate the impact? Patch releases are only for critical fixes (not important), also exercised on prominent code path.
|
The above commits in ml-commons are all bug fixes and tutorial document improvement. They are all needed in 2.17.1. |
The above commits in k-NN are all critical performance improvements. These improvements are mainly in the areas of disk optimized vector search, which is a new feature being launched in 2.17.0. |
@Zhangxunmt Thanks for dropping in the comment. Can you please help anwer few of the questions on the fixes to help evaluate the urgency/criticality :
I will like to iterate that this patch release should only contain critical bugs or cve fixes to unblock open-source users. For ex this change doesn't look like a critical fix. |
Yes they are all related to the new feature in 2.17.
Yes, 1 more feature flag to include in this PR. opensearch-project/ml-commons#2982
These are the bugs after the bug bash in 2.17. The bug bash happened only after 2.17 RC was available. After the bugs fixed, there weren't enough time left for 2.17.
These bugs will impact the usefulness of the new feature in 2.17.
They were called out after multiple times before the release. But they were not included in the final RC.
This comes along with the 2.17 features so it's better to have them in 2.17. |
opensearch-project/k-NN#2132
Both are performance related Is this feature under a feature flag or explicit setting? How does this bug surface? Is it the most exercised flow? What is the impact of this bug? Performance impact Why was this not called out yet? These were merged pretty close to release and the performance impact was identified as a part of review nightly benchmark runs metrics. The review happens weekly Why this cannot wait until 2.18? User will have a bad experience with higher latencies |
@Zhangxunmt @shatejas Anything introduced as a new feature in 2.17 or under a Feature Flag do not qualify as a critical fix for patch release. Critical Fixes are only for changes where an open-source user will need to revert back due to failure or poor experience post upgrade. Can we please eliminate the ones which are new features or under feature flag, and list those still qualifying as critical. |
|
|
[Notifications] Fix for broken deny list and update to check for all resolved IPs in the deny list to be included in this patch release - opensearch-project/notifications#964 |
Release Candidate Details for 2.17.1OpenSearch - Build 10331
Check how to install opensearch and dashboards on different platforms |
Core Components CommitID(after 2024-09-27) & Release Notes info
|
Latest Release Candidate Details for 2.17.1OpenSearch - Build 10332
Check how to install opensearch and dashboards on different platforms |
Integration Test Results
Thank you |
opensearch-project/k-NN/2152 |
Integration Test Results
Thank you |
Native Plugin Validation
|
Signature validation
|
OpenSearch 2.17.1 has been released to the public |
Release OpenSearch and OpenSearch Dashboards 2.17.1
I noticed that a manifest was automatically created in manifests/2.17.1. Please follow the following checklist to make a release.
How to use this issue
This Release Issue
This issue captures the state of the OpenSearch release, its assignee (Release Manager) is responsible for driving the release. Please contact them or @mention them on this issue for help. There are linked issues on components of the release where individual components can be tracked. For more information check the the Release Process OpenSearch Guide.
Please refer to the following link for the release version dates: Release Schedule and Maintenance Policy.
Entrance Criteria
OpenSearch 2.17.1 exit criteria status:
OpenSearch-Dashboards 2.17.1 exit criteria status:
Preparation
Campaigns
Version Increment - _Ends September 24th 2024
Code Complete - _Ends September 24th 2024
Release Candidate Creation and Testing - _Ends September 25th 2024
Performance testing validation - _Ends September 25th 2024
Pre Release - _Ends September 30th 2024
Release - _Ends October 1st 2024
Release Checklist.
Release Checklist
Pre-Release activities
Release activities
Completed validation for <>
in the logs).Post Release
Components
Replace with links to all component tracking issues.
Legend
The text was updated successfully, but these errors were encountered: