Add git credential fetch support, minor bug fixes #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2057 +/- ##
=========================================
Coverage 94.23% 94.23%
Complexity 25 25
=========================================
Files 198 198
Lines 3902 3902
Branches 29 29
=========================================
Hits 3677 3677
Misses 219 219
Partials 6 6 Continue to review full report at Codecov.
|
| ].join(' ')) | ||
| String stackNameSuffix = isNullOrEmpty(args.stackNameSuffix) ? 'perf-test' : args.stackNameSuffix | ||
|
|
||
| withCredentials([usernamePassword(credentialsId: "${GITHUB_BOT_TOKEN_NAME}", usernameVariable: 'GITHUB_USER', passwordVariable: 'GITHUB_TOKEN')]) { |
There was a problem hiding this comment.
I dont see anywhere define the actual token id, are you setting it in the jenkins global env?
There was a problem hiding this comment.
It is defined as a Jenkins global env var. More usages -
,
peterzhuamazon
approved these changes
Apr 29, 2022
|
@opensearch-project/engineering-effectiveness I need some help merging this in. I do not currently have write permissions to this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kunal Kotwani kkotwani@amazon.com
Description
stackNameSuffixto prevent two builds with the same build id use the same infra stackconfigunder the perf test scriptIssues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.