Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade to cypress@^10.8.0 to resolve path separator issues #370

Open
peterzhuamazon opened this issue Nov 3, 2022 · 10 comments
Open
Assignees

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 3, 2022

Hi All,

2.4.0 cypress windows CI on github failed with these error:
https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3383921006/jobs/5620287472#step:14:159


  1) Create datasources
       should successfully load the page:
     AssertionError: Timed out retrying after 60000ms: Expected to find content: 'Create a new data source connection to help you retrieve data from an external OpenSearch compatible source.' but never did.
      at Context.eval (http://localhost:5601/__cypress/tests?p=cypress\integration\core-opensearch-dashboards\opensearch-dashboards\datasource-management-plugin\1_create_datasource.spec.js:123:10)

  2) Create datasources
       should successfully show the experimental feature callout:
     AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="data-source-experimental-call"]`, but never found it.
      at Context.eval (http://localhost:5601/__cypress/tests?p=cypress\integration\core-opensearch-dashboards\opensearch-dashboards\datasource-management-plugin\1_create_datasource.spec.js:128:62)

Related to Cypress version have to update to at least 10.8.0:

We might also need to consider upgrade to 10.11.0 which is the latest version as the writing of this issue:
https://docs.cypress.io/guides/references/changelog#10-11-0

Thanks.

@peterzhuamazon
Copy link
Member Author

@seraphjiang @tianleh

@peterzhuamazon
Copy link
Member Author

Seems like cypress 10 does not support cypress.json anymore and requires some migration:
https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3384251969/jobs/5620995705#step:11:85

There is a cypress.json file at the path: D:\a\opensearch-dashboards-functional-test\opensearch-dashboards-functional-test\cypress-test

Cypress version 10.0.0 no longer supports cypress.json.

Please run cypress open to launch the migration tool to migrate to cypress.config.{js,ts,mjs,cjs}.

https://on.cypress.io/migration-guide

@tianleh
Copy link
Member

tianleh commented Nov 3, 2022

Will do after 2.4.0 release

@bbarani
Copy link
Member

bbarani commented Nov 3, 2022

@tianleh @seanneumann @seraphjiang Lets target this for 1.3.7 release scheduled for Dec 08 2022

@CEHENKLE
Copy link
Member

CEHENKLE commented Nov 3, 2022

@tianleh @seanneumann @seraphjiang Lets target this for 1.3.7 release scheduled for Dec 08 2022

Yes, please.

@peterzhuamazon peterzhuamazon removed their assignment Nov 3, 2022
@dblock dblock changed the title [BUG] Windows Cypress requires to use cypress@^10.8.0 to resolve path separator issues [BUG] Upgrade to cypress@^10.8.0 to resolve path separator issues Nov 3, 2022
@dblock
Copy link
Member

dblock commented Nov 3, 2022

Renamed the issue to upgrade to 10+, assigned to @tianleh.

@peterzhuamazon
Copy link
Member Author

Latest development to use cypress 9 version is also running, the reason it failed is because data source is not enabled as well as vis_builder.

@tianleh
Copy link
Member

tianleh commented Nov 16, 2022

Latest development to use cypress 9 version is also running, the reason it failed is because data source is not enabled as well as vis_builder.

Great! In this case, do we still need to handle Cypress 10 upgrade as a priority, especially for 1.3.7? @peterzhuamazon

@peterzhuamazon
Copy link
Member Author

Latest development to use cypress 9 version is also running, the reason it failed is because data source is not enabled as well as vis_builder.

Great! In this case, do we still need to handle Cypress 10 upgrade as a priority, especially for 1.3.7? @peterzhuamazon

Hi @tianleh this is not a priority now, we are able to run cypress on Windows for the past week and it runs well.
Although upgrading to v10 would still be nice for the long term later.

Thanks.

@tianleh
Copy link
Member

tianleh commented Nov 16, 2022

Sure. Let me remove the 1.3.7 label then

@tianleh tianleh removed the 1.3.7 label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants