From c200d432ab92fd0432abcf2a1cf9e707da86c60a Mon Sep 17 00:00:00 2001
From: Andriy Redko <andriy.redko@aiven.io>
Date: Tue, 12 Dec 2023 11:59:11 -0500
Subject: [PATCH] Restore support for Java 8

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
---
 CHANGELOG.md                                           |  1 +
 java-client/build.gradle.kts                           | 10 ++++++++--
 .../client/transport/aws/AwsSdk2Transport.java         |  2 +-
 samples/build.gradle.kts                               |  4 ++--
 4 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 57d0e388e0..2a8c2a5c9e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -41,6 +41,7 @@ This section is for maintaining a changelog for all breaking changes for the cli
 ### Dependencies
 
 ### Changed
+- Restore support for Java 8 ([#767](https://github.com/opensearch-project/opensearch-java/pull/767))
 
 ### Deprecated
 - Deprecated "_toQuery()" in Query and QueryVariant ([#760](https://github.com/opensearch-project/opensearch-java/pull/760)
diff --git a/java-client/build.gradle.kts b/java-client/build.gradle.kts
index b8faacdbc5..3a1169c3ad 100644
--- a/java-client/build.gradle.kts
+++ b/java-client/build.gradle.kts
@@ -63,9 +63,15 @@ configurations {
     }
 }
 
+// The tests are using OpenSearch core test framework, that has JDK-11 baseline
+tasks.named<JavaCompile>("compileTestJava") {
+    sourceCompatibility = JavaVersion.VERSION_11.toString()
+    targetCompatibility = JavaVersion.VERSION_11.toString()
+}
+
 java {
-    targetCompatibility = JavaVersion.VERSION_11
-    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_1_8
+    sourceCompatibility = JavaVersion.VERSION_1_8
 
     withJavadocJar()
     withSourcesJar()
diff --git a/java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java b/java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java
index 2e4145f3bb..313f9c4d1d 100644
--- a/java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java
+++ b/java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java
@@ -293,7 +293,7 @@ private <RequestT> SdkHttpFullRequest prepareRequest(
         Map<String, String> params = endpoint.queryParameters(request);
         if (params != null && !params.isEmpty()) {
             char sep = '?';
-            for (var ent : params.entrySet()) {
+            for (Map.Entry<String, String> ent : params.entrySet()) {
                 url.append(sep).append(ent.getKey()).append('=');
                 url.append(URLEncoder.encode(ent.getValue(), StandardCharsets.UTF_8));
                 sep = '&';
diff --git a/samples/build.gradle.kts b/samples/build.gradle.kts
index 89514190be..0e63e6a821 100644
--- a/samples/build.gradle.kts
+++ b/samples/build.gradle.kts
@@ -13,8 +13,8 @@ plugins {
 }
 
 java {
-    targetCompatibility = JavaVersion.VERSION_11
-    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_1_8
+    sourceCompatibility = JavaVersion.VERSION_1_8
 }
 
 dependencies {