Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for inclusive naming #89

Closed
wbeckler opened this issue Aug 26, 2022 · 2 comments
Closed

[FEATURE] Add support for inclusive naming #89

wbeckler opened this issue Aug 26, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@wbeckler
Copy link

Add support for inclusive naming by deprecating the master nomenclature.

See meta issue opensearch-project/opensearch-clients#16 for details.

@Yury-Fridlyand
Copy link
Collaborator

@wbeckler,
This is already done in scope of #51.

  • All master references replaced by cluster_manager
    except
    master references in API (it is marked as obsolete, but not removed yet) and in comments to these API:
    • master node renamed to cluster_manager (actually duplicated for BWC with OpenSearch 1.x)
    • master_timeout field renamed to cluster_manager_timeout (duplicated too)
    • masterEligible duplicated by clusterManagerEligible (not an OpenSearch API, but might be in use by customer applications)
  • Fortunately, no blacklist/whitelist references in the client code/API, nothing to do there.

Please, check if something is missed and report here. Otherwise we can close this ticket once #51 merged.

@harshavamsi
Copy link
Contributor

@wbeckler @Yury-Fridlyand can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants