Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mapping types #8

Closed
dreamer-89 opened this issue Mar 2, 2022 · 4 comments
Closed

Remove mapping types #8

dreamer-89 opened this issue Mar 2, 2022 · 4 comments
Labels
enhancement New feature or request v2.0.0

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Mar 2, 2022

As part of v2.0 release, mapping types are getting removed from OpenSearch engine. Below are the changes in the opensearch-engine.

  • Removal of type from rest end-points
  • Removal of include_type_name parameter from API requests.

As part of this issue, please verify if type removal change on OpenSearch engine impacts this repository. If yes, then please remove the type references/usage from this repository

Top level changes are captured in gist below:
https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

For more detailed changes, please check meta issue below:
Related: OpenSearch-engine meta issue

@dreamer-89 dreamer-89 added the enhancement New feature or request label Mar 2, 2022
@dreamer-89
Copy link
Member Author

This change goes in v2.0.0 release in OpenSearch repository and is a breaking change. Request maintainer to add appropriate labels.

@dreamer-89
Copy link
Member Author

I looked into this repository source code but did not find any usages of mapping types. @samuel-oci : can you please have a look and confirm ?

@samuel-oci
Copy link
Collaborator

Hi @dreamer-89 will check and confirm, should be back shortly with an answer.

@samuel-oci
Copy link
Collaborator

Confirmed that mapping types are not used in this repository code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.0.0
Projects
None yet
Development

No branches or pull requests

3 participants