Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Respect SSL certificate environment variables #111

Closed
aiudirog opened this issue Jan 13, 2022 · 1 comment · Fixed by #196
Closed

[FEATURE] Respect SSL certificate environment variables #111

aiudirog opened this issue Jan 13, 2022 · 1 comment · Fixed by #196
Labels
enhancement New feature or request

Comments

@aiudirog
Copy link
Contributor

Is your feature request related to a problem?
I can't configure SSL cert files with the urllib3 backend through environment variables because certifi is chosen by default here:

CA_CERTS = certifi.where()

This is preventing me from configuring a company SSL certificate on the fly when deploying to Lambda which isn't required in other deployments.

What solution would you like?
Check SSL_CERT_FILE/SSL_CERT_DIR environment variables before defaulting to certifi's CA bundle.

What alternatives have you considered?
You can configure it manually in code, but this makes portable deployments more challenging.

Do you have any additional context?
N/A

@wbeckler
Copy link
Contributor

wbeckler commented Aug 5, 2022

@aiudirog Feel free to create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants