Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Lower the number of approvers required for this repo #1010

Closed
dblock opened this issue Jul 14, 2024 · 3 comments
Closed

[PROPOSAL] Lower the number of approvers required for this repo #1010

dblock opened this issue Jul 14, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Jul 14, 2024

What/Why

What are you proposing?

Lower the number of approvers required to merge a PR into this repo from 2 to 1.

What users have asked for this feature?

All contributors.

What problems are you trying to solve?

Dependabot issues sit unnecessarily long for a non-production repo.

What will it take to execute?

If majority of maintainers agree, I can make the change. Add a +1.

@joshpalis
@owaiskazi19
@ryanbogan
@saratvemulapalli
@dbwiddis

@dblock dblock added enhancement New feature or request and removed untriaged labels Aug 5, 2024
@dblock
Copy link
Member Author

dblock commented Aug 5, 2024

[Catch All Triage - 1, 2, 3]

Can I please have a +1 from @owaiskazi19 @ryanbogan @dbwiddis @joshpalis ?

@dbwiddis
Copy link
Member

@dblock all +1s as asked.

@dblock
Copy link
Member Author

dblock commented Aug 27, 2024

I've lowered the setting.

@dblock dblock closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants