-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OuiHeader background to use the same value as OuiPageBackgroundColor #901
Comments
@KrooshalUX Currently the Screen.Recording.2023-07-20.at.4.20.48.PM.movoui/src/global_styling/variables/_header.scss Lines 12 to 16 in f718f63
So what should we do for when the dark header prop is set (in both light and dark site themes?) |
The actual values: Next dark:
Next:
|
"So what should we do for when the dark header prop is set (in both light and dark site themes?)" - good question. The idea behind using the background page color as the navigation background color is to help the page content "pop" and give a lighter, less chrome-heavy feeling to the application (there is more to do in this regard, like perhaps removing the bottom border, but thats TBD after seeing the result of this change IRL). So, in that lens - my overall concern is regarding the defaults - less so decisions the dashboards customer/builder may have chosen (ex: dark mode navigation in a light mode interface). I imagine deprecating this at this phase will cause unexpected chaos, so for users/customers/builders who have manually set this, if they are using light mode but set the header to dark mode, it wont have the same appearance effect, but at least it would reflect the correct color (vs what appears to be a much darker color than I intended). |
No description provided.
The text was updated successfully, but these errors were encountered: