Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dashboards settings in report configurations #41

Open
zhongnansu opened this issue May 13, 2021 · 0 comments
Open

Use dashboards settings in report configurations #41

zhongnansu opened this issue May 13, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request feature request good first issue Good for newcomers
Milestone

Comments

@zhongnansu
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.


Currently, the time_range component uses a constant from report_settings_constants.tsx to feed the commonlyUsedRanges property of EuiSuperDatePicker inside it.

This is not the default behavior across Kibana. The default behavior is to load this from uiSettings service, allowing the user to override the available options.

I'm proposing this change that is not a breaking change but a "fix" that makes this plugin follow the default behavior across Kibana.

This issue was originally submitted by @iget-master
opendistro-for-elasticsearch/kibana-reports#351

@zhongnansu zhongnansu added bug Something isn't working Beta untriaged labels May 13, 2021
@zhongnansu zhongnansu removed the Beta label May 13, 2021
@zhongnansu zhongnansu added this to the may-bug-bash milestone May 14, 2021
@zhongnansu zhongnansu self-assigned this May 14, 2021
@zhongnansu zhongnansu changed the title [BUG] Time Range not using Commonly Used Ranges from Kibana Settings [BUG] Time Range not using Commonly Used Ranges from OpenSearch Dashboards Settings May 21, 2021
@anirudha anirudha added enhancement New feature or request and removed bug Something isn't working untriaged labels Jun 8, 2021
@anirudha anirudha changed the title [BUG] Time Range not using Commonly Used Ranges from OpenSearch Dashboards Settings Time Range not using Commonly Used Ranges from OpenSearch Dashboards Settings Dec 21, 2021
@anirudha anirudha changed the title Time Range not using Commonly Used Ranges from OpenSearch Dashboards Settings Use dashboards settings in report configurations Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants