Validate OUI theme compliance - phase 1

[joshuarrrr]

This is a tracking issue for phase 1 of OUI theme plugin compliance, which will involve changes to OUI typography and color SASS variables (for both dark and light mode). For full details, including dates and tooling, see opensearch-project/OpenSearch-Dashboards#4291

If your plugin has no UI views or components, please add a comment to that effect, and we'll remove the repo from future look and feel update campaigns.

Actions required

• Acknowledge the issue by adding an assignee who will serve as a point-of-contact
• Provide screenshots and navigation instructions for important views and screens in your plugin or application. This will assist with both manual and automatic validation of compliance
• Identify all typographic properties and styles
• Create issues to mitigate typographic styles not inherited from OUI components or SASS variables
• Identify all color values, including visualization colors and palettes
• Create issues to mitigate typographic styles not inherited from OUI components or SASS variables
• Resolve all mitigation issues
• Validate and test plugin with updated OUI theme

Priority issues:

• [FEATURE] OpenSearch logo should inherit from OpenSearch Dashboards branding configuration (and be theme-aware) #1524

Questions?

Add a comment on opensearch-project/OpenSearch-Dashboards#4291

[stephen-crawford]

[Triage] Hi @joshuarrrr, thank you for making this issue for us. Looking at the linked issue I see:

"We expect to ship the updated theme as an experimental/optional theme in the 2.9 release (code freeze July 11, 2023), and to make it the default theme in 2.10 (code freeze August 22, 2023). In order for the UX time to review and approve all plugins, actions should be completed by August 6, 2023."

Can you confirm when you want these tasks completed? Thank you.

[joshuarrrr]

@scrawfor99 Dates may be subject to change, but yes August 6 is the expected deadline.

[stephen-crawford]

Hi @joshuarrrr, thanks for the clarification. We just wanted to check whether we should have it all done by 7/11 and then have it approved by 8/6 or just by 8/6.

[stephen-crawford]

I believe many of these items have been completed by tasks linked off #1531. I will handle correcting the issues but it seems like the typography and graphics have already been checked based on the filing of the other issues #1529 and #1527.

[stephen-crawford]

Waiting on this change: opensearch-project/OpenSearch-Dashboards#4702

[stephen-crawford]

opensearch-project/OpenSearch-Dashboards#4702 is still in progress with some feedback from the OUI team.

[stephen-crawford]

opensearch-project/OpenSearch-Dashboards#4702 is merged, waiting on backport.

[stephen-crawford]

opensearch-project/OpenSearch-Dashboards#4796 is the backport

[stephen-crawford]

Hi @joshuarrrr,

I just finished looking things over.

While validating security dashboards plugin, I noticed that the previous tab on the top bar showing your webpage path seems to auto highlight. See this photo for example:

Note that "Dashboards Ma..." is highlighted. This was without my mouse over the button. Based on the behavior in light mode, it looks like this is intentional, but I am not sure if we want the current color choice.

I also noticed that Security makes use of the grey text instead of the white text that some other areas use:

This is not wrong, since we still use the theme from core, but I did notice it was different.

Everything else looks correct.

Let me know if anything else needs to be done, if not I will close this issue.

[peternied]

I am considering this validation complete for v2.10 There are separate issues tracking areas where validation didn't succeed.