Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support multiple datasources in the "Service Accounts" tab #1799

Closed
Tracked by #1794
derek-ho opened this issue Feb 22, 2024 · 5 comments
Closed
Tracked by #1794

[FEATURE] Support multiple datasources in the "Service Accounts" tab #1799

derek-ho opened this issue Feb 22, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request triaged

Comments

@derek-ho
Copy link
Collaborator

Is your feature request related to a problem?
Support multiple datasources functionality in the "Service Accounts" tab.

Acceptance criteria

  • Data source picker shared component is present on the page with a sensible UX
  • Data source selections that should be persisted across tabs is accurately persisted
  • Selected datasource prior to landing on this page is correctly populated (if applicable), and defaults are selected if not applicable

What solution would you like?
Support multiple datasources in the "Service Accounts" tab.

What alternatives have you considered?
None

Do you have any additional context?
Depends on #1795 to have data source picker available.

@derek-ho derek-ho added enhancement New feature or request untriaged labels Feb 22, 2024
@derek-ho
Copy link
Collaborator Author

@cwperks can you provide some color here on whether you think this is appropriate? I see that this was not backported to 2.x and the UI seems to have limited functionality. Is there a reason why this isn't backported? Does it make sense to keep it in main but not 2.x and if we keep it should we support multiple datasources for it?

@cwperks
Copy link
Member

cwperks commented Feb 22, 2024

@derek-ho The selector should be on all pages including this one, but the other pages have priority. I left some thoughts on the original PR here. IMO it has limited support atm so I don't think it should be backported to 2.x and perhaps reverted if there is no plan for long term support.

@derek-ho
Copy link
Collaborator Author

[Triage] This is part of the meta of supporting multi datasources in the security plugin.

@zhongnansu
Copy link
Member

Hi Derek, is this completed by #1870, can we close? @derek-ho

@derek-ho
Copy link
Collaborator Author

Code in feature branch not in main yet, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

3 participants