Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch Dashboard custom branding doesn't apply to the login screen #915

Open
laila-sul opened this issue Mar 3, 2022 · 6 comments
Open
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed, need help from community triaged

Comments

@laila-sul
Copy link

laila-sul commented Mar 3, 2022

Is your feature request related to a problem? Please describe.
I'm trying to customize the login screen on OpenSearch, and as far as I understood it's a part of the security plugging
Describe the solution you'd like
it would be useful to consider the login screen customization as a part of custom branding features
temp1

@laila-sul laila-sul added the enhancement New feature or request label Mar 3, 2022
@peternied
Copy link
Member

[Triage] We are the OpenSearch project, we would want to keep the OpenSearch / OpenSearch Dashboard names as is.

@elfisher Do you have thoughts on what kind customizations we would want to support and if we should reconsider.

@peternied
Copy link
Member

@opensearch-project/opensearch-ux Do you have thoughts on what kind customizations we would want to support and if we should reconsider keeping the UI as is?

@kgcreative
Copy link
Member

kgcreative commented Apr 8, 2022

@peternied - I believe custom branding includes some configs you can hook onto: See this PR: opensearch-project/OpenSearch-Dashboards#826 and the relevant configs (opensearchDoashboards.branding.logo, opensearchDoashboards.branding.applicationTitle)

This way the login screen can consume the custom branding config

@peternied
Copy link
Member

Thanks @kgcreative it looks like we missed adding this customization logic into the login screen, thanks for referencing that pull request.

@peternied peternied added the bug Something isn't working label Apr 8, 2022
@peternied peternied changed the title Login screen customization OpenSearch Dashboard custom branding doesn't apply to the login screen Apr 8, 2022
@peternied peternied added the help wanted Extra attention is needed, need help from community label Apr 8, 2022
@kgcreative
Copy link
Member

Relevant docs: https://opensearch.org/docs/latest/dashboards/branding/

@amanthakur
Copy link

@peternied

,external_osdSharedDeps_React_default.a.createElement(external_osdSharedDeps_ElasticEui_["EuiText"],{size:"m",textAlign:"center"},props.config.title|| ("please login open Search Dashboard ")

i want this with my custom text but when i am changing it my custom text is not visual on login page there is same text please anyone can help me change this ????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed, need help from community triaged
Projects
None yet
Development

No branches or pull requests

5 participants