From 892a99ad2279b88c33557a50c174a3fe64131a59 Mon Sep 17 00:00:00 2001
From: Peter Nied <petern@amazon.com>
Date: Tue, 15 Aug 2023 15:03:46 -0500
Subject: [PATCH] [Backport 2.x][Build Break] Disable gradlew build cache to
 ensure most up-to-date dependencies (#3187)

Backport 5e8f12c from #3186.

Disable gradlew build cache to ensure most up-to-date dependencies

We suspect that we are seeing the snapshot build of opensearch be cached
in some circumstances and not cached in others that is creating a mix of
build failures that are hard to interpret.

Follow up issue to revisit and potentially renable this setting
https://github.com/opensearch-project/security/issues/3185

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 5e8f12c)
---
 .github/actions/create-bwc-build/action.yaml | 1 +
 .github/actions/run-bwc-suite/action.yaml    | 1 +
 .github/workflows/ci.yml                     | 1 +
 .github/workflows/code-hygiene.yml           | 3 +++
 .github/workflows/plugin_install.yml         | 2 ++
 5 files changed, 8 insertions(+)

diff --git a/.github/actions/create-bwc-build/action.yaml b/.github/actions/create-bwc-build/action.yaml
index fcfa612a7d..bfe64ff59b 100644
--- a/.github/actions/create-bwc-build/action.yaml
+++ b/.github/actions/create-bwc-build/action.yaml
@@ -35,6 +35,7 @@ runs:
     - name: Build
       uses: gradle/gradle-build-action@v2
       with:
+        cache-disabled: true
         arguments: assemble -Dbuild.snapshot=false
         build-root-directory: ${{ inputs.plugin-branch }}
 
diff --git a/.github/actions/run-bwc-suite/action.yaml b/.github/actions/run-bwc-suite/action.yaml
index 4614872858..6771faddab 100644
--- a/.github/actions/run-bwc-suite/action.yaml
+++ b/.github/actions/run-bwc-suite/action.yaml
@@ -31,6 +31,7 @@ runs:
     - name: Run BWC tests
       uses: gradle/gradle-build-action@v2
       with:
+        cache-disabled: true
         arguments: |
           bwcTestSuite
           -Dtests.security.manager=false
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4b0841bd11..28a0c4ebf5 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -49,6 +49,7 @@ jobs:
     - name: Build and Test
       uses: gradle/gradle-build-action@v2
       with:
+        cache-disabled: true
         arguments: |
           ${{ matrix.gradle_task }} -Dbuild.snapshot=false
           -x test
diff --git a/.github/workflows/code-hygiene.yml b/.github/workflows/code-hygiene.yml
index f078cb2b56..756ca0b9c3 100644
--- a/.github/workflows/code-hygiene.yml
+++ b/.github/workflows/code-hygiene.yml
@@ -26,6 +26,7 @@ jobs:
 
       - uses: gradle/gradle-build-action@v2
         with:
+          cache-disabled: true
           arguments: spotlessCheck
 
   checkstyle:
@@ -41,6 +42,7 @@ jobs:
 
       - uses: gradle/gradle-build-action@v2
         with:
+          cache-disabled: true
           arguments: checkstyleMain checkstyleTest
 
   spotbugs:
@@ -56,4 +58,5 @@ jobs:
 
       - uses: gradle/gradle-build-action@v2
         with:
+          cache-disabled: true
           arguments: spotbugsMain
diff --git a/.github/workflows/plugin_install.yml b/.github/workflows/plugin_install.yml
index c281a7fbc4..14bd2eaa13 100644
--- a/.github/workflows/plugin_install.yml
+++ b/.github/workflows/plugin_install.yml
@@ -27,6 +27,7 @@ jobs:
       - name: Assemble target plugin
         uses: gradle/gradle-build-action@v2
         with:
+          cache-disabled: true
           arguments: assemble
 
       - name: Create Setup Script
@@ -53,4 +54,5 @@ jobs:
       - name: Run sanity tests
         uses: gradle/gradle-build-action@v2
         with:
+          cache-disabled: true
           arguments: integTestRemote -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="opensearch" -Dhttps=true -Duser=admin -Dpassword=admin