Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Move json-smart into dev dependencies? #1455

Closed
dblock opened this issue Sep 22, 2021 · 1 comment
Closed

[BUG] Move json-smart into dev dependencies? #1455

dblock opened this issue Sep 22, 2021 · 1 comment
Labels
invalid This doesn't seem right

Comments

@dblock
Copy link
Member

dblock commented Sep 22, 2021

Describe the bug

Looking at the pom I am seeing json-smart pulled in. This ends up shipping as ./plugins/opensearch-security/json-smart-2.4.7.jar. If I am not mistaken this is only used in tests and should be removed.
@dblock dblock added bug Something isn't working Beta untriaged Require the attention of the repository maintainers and may need to be prioritized labels Sep 22, 2021
@dblock dblock mentioned this issue Sep 22, 2021
Closed
@vrozov
Copy link
Contributor

vrozov commented Sep 23, 2021

json-smart is the transitive dependency of json-path and json-path is used in production code

@vrozov vrozov added invalid This doesn't seem right and removed bug Something isn't working Beta untriaged Require the attention of the repository maintainers and may need to be prioritized labels Sep 23, 2021
@cliu123 cliu123 closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dblock @vrozov @cliu123