Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Security Plugin does not have batch script for install demo configurations for windows #2148

Closed
peterzhuamazon opened this issue Oct 6, 2022 · 9 comments
Labels
bug Something isn't working sprint backlog triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. windows

Comments

@peterzhuamazon
Copy link
Member

As a follow up to this issue:
#2122

The install demo configuration script is only available in Shell form.
This means it is not possible to run it in Windows env.

In ODFE we run the script pre-configured for user in LINUX machine before assembling the windows zip.
We have to do the same now for OpenSearch: opensearch-project/opensearch-build#2704.

The above is a temporary solution and we achieve this change by utilizing the mingw env within the windows jenkins agent, simulating a linux shell env to generate the demo certs, or the start up of the cluster will fail with security installed.

We think it is a better solution if security team can provide a batch file version of the install demo configuration script so we can resolve this issue natively on Windows without the need to pre-populate the certs for users, or simulating a LINUX shell env on Windows, as it is not done in Tarball as of yet.

Thanks.

@peterzhuamazon peterzhuamazon added bug Something isn't working windows labels Oct 6, 2022
@peterzhuamazon peterzhuamazon changed the title [BUG] Security Plugin does not have batch script for install demo configurations [BUG] Security Plugin does not have batch script for install demo configurations for windows Oct 6, 2022
@peternied peternied added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Oct 7, 2022
@vinayak15
Copy link
Contributor

[Triaged] @cwperks Can you please follow up with peterzhuamazon regarding this issue.

@davidlago davidlago added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 10, 2022
@cwperks
Copy link
Member

cwperks commented Oct 26, 2022

@peterzhuamazon @bbarani The script for the batch file of install_demo_configuration.bat is written and verified using multiple workspaces and automated with a windows-latest github runner against 2.x. There is currently a problem with the automated validation on 3.0.0 which is being resolved. See comment here (#2161 (comment)) for context.

According to the discussion on here (opensearch-project/OpenSearch#4942) - one solution is for core to revert a recent change that prevents opensearch nodes to be brought up on the github runners and re-work the change.

@peterzhuamazon
Copy link
Member Author

Thanks @cwperks waiting for the backport of this:
opensearch-project/OpenSearch#4949

@minalsha
Copy link

@cwperks opensearch-project/OpenSearch#4949 has been merged.

@cwperks
Copy link
Member

cwperks commented Oct 27, 2022

Thank you @minalsha and @peterzhuamazon ! Would it be possible to create another snapshot distribution with the change included. We pull the snapshot distribution from here: https://github.com/opensearch-project/security/pull/2161/files#diff-3e971aab38c741b1cb89584068ce23192213a18b1ecc885ac7b450bf5a5bb86eR89

@peterzhuamazon
Copy link
Member Author

Thank you @minalsha and @peterzhuamazon ! Would it be possible to create another snapshot distribution with the change included. We pull the snapshot distribution from here: https://github.com/opensearch-project/security/pull/2161/files#diff-3e971aab38c741b1cb89584068ce23192213a18b1ecc885ac7b450bf5a5bb86eR89

Hi @cwperks Im working on that right now might take some time.
Thanks.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Oct 27, 2022

Ignore my last comment it is quicker than I think:
https://build.ci.opensearch.org/job/distribution-build-opensearch/6322

@cwperks
Copy link
Member

cwperks commented Oct 27, 2022

The most recent windows plugin-install new CI step has completed successfully with the new snapshot build! https://github.com/opensearch-project/security/actions/runs/3340448709/jobs/5530552763

@cwperks
Copy link
Member

cwperks commented Oct 31, 2022

Closing this ticket since the Batch script is merged. I will file a new issue with the plugin-install.yml github action to run the opensearch node as a user other than administrator.

@cwperks cwperks closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sprint backlog triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. windows
Projects
None yet
Development

No branches or pull requests

6 participants