Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Ensure changes to admin credentials work on all supported OpenSearch distributions #3623

Closed
9 tasks done
DarshitChanpura opened this issue Oct 30, 2023 · 3 comments
Closed
9 tasks done
Assignees
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.12.0 Items targeting 2.12.0

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Oct 30, 2023

High-level Idea

Stemming from the spike, this feature-requests focuses on ensuring all distributions work as expected once the hardcoded admin password has been replace with a more dynamic value.
This issue should be worked in tandem with the meta to update the code to replace hardcoded admin password inside demo configuration script.

Acceptance Criteria

  • The modification is implemented in all compatible OpenSearch distributions.
  • The change is reflected consistently across all supported OpenSearch distributions.

Exit Criteria

@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Oct 30, 2023
@stephen-crawford
Copy link
Contributor

[Triage] This is another meta issue related to the work of removing the use of default credentials. Marking as triaged given clear exit criteria and action items.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 30, 2023
@DarshitChanpura DarshitChanpura changed the title [META] Replace hardcoded instance of admin credentials across all supported OpenSearch distributions [META] Ensure changes to admin credentials work on all supported OpenSearch distributions Nov 28, 2023
@derek-ho
Copy link
Collaborator

derek-ho commented Nov 29, 2023

There are three test cases for each distribution type that needs to be verified:

  1. Run without initialAdminPassword environment variable set, no initialAdminPassword.txt.
    a. Verify a secure password is generated
    b. Verify that admin:admin fails authentication
    c. Verify that admin:${Generated Password} succeeds authentication
  2. Run with initialAdminPassword environment variable set
    a. Verify that a "weak" password fails and stops script execution in a clean way
    b. Verify that a "strong" password succeeds
    i. Verify that admin:admin fails authentication
    ii. Verify that admin:${initialAdminPassword} succeeds authentication
  3. Run without initialAdminPassword environment variable set, initialAdminPassword.txt present.
    a. Verify that a "weak" password fails and stops script execution in a clean way
    b. Verify that a "strong" password succeeds
    i. Verify that admin:admin fails authentication
    ii. Verify that admin:${initialAdminPassword.txt contents} succeeds authentication

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 4, 2024

acceptance criteria met. Refer each individual issues for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.12.0 Items targeting 2.12.0
Projects
None yet
Development

No branches or pull requests

3 participants