Build OpenSearch in CD workflow in order to build security plugin #1364
Conversation
cliu123
force-pushed
the
build_opensearch_in_cd
branch
from
26a1ea1 to
bfc1d2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1364 +/- ##
=========================================
Coverage 64.78% 64.78%
- Complexity 3204 3205 +1
=========================================
Files 247 247
Lines 17252 17252
Branches 3053 3053
=========================================
+ Hits 11176 11177 +1
+ Misses 4526 4525 -1
Partials 1550 1550
Continue to review full report at Codecov.
|
…t to maven central
.github/workflows/cd.yml
Outdated
| path: OpenSearch | ||
| ref: '1.0' | ||
|
|
||
| - name: Build OpenSearch |
There was a problem hiding this comment.
Should this step be after Cache Maven packages step?
There was a problem hiding this comment.
Shouldn't OpenSearch artifact built be cached?
If moving Build OpenSearch step and putting it after Cache Maven packages step, both of Build OpenSearch and Build steps will be after Cache Maven packages step. Shouldn't the build outputs be cached?
There was a problem hiding this comment.
What is the point of caching OpenSearch maven packages when they are rebuilt anyway?
There was a problem hiding this comment.
Agree. In this case, only downloaded dependencies should be cached. There is no point of caching build outputs.
Moved. Thanks!
opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Github Issue # or road-map entry, if available:
Description of changes:
Why these changes are required?
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
Is it backport from main branch? (If yes, please add backport PR # and commits #)
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.