Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Setup auth token utils for obo #3419

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Sep 27, 2023

Description

Setup auth token utils for obo

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Enhancement, New feature

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #3419 (78ce0e7) into main (8628a89) will increase coverage by 0.28%.
Report is 6 commits behind head on main.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3419      +/-   ##
============================================
+ Coverage     64.23%   64.52%   +0.28%     
- Complexity     3490     3546      +56     
============================================
  Files           264      269       +5     
  Lines         20152    20363     +211     
  Branches       3363     3375      +12     
============================================
+ Hits          12945    13139     +194     
+ Misses         5530     5529       -1     
- Partials       1677     1695      +18     
Files Coverage Δ
...g/opensearch/security/authtoken/jwt/JwtVendor.java 75.75% <100.00%> (ø)
...nsearch/security/http/OnBehalfOfAuthenticator.java 68.31% <0.00%> (+0.66%) ⬆️
...ch/security/securityconf/DynamicConfigModelV7.java 66.30% <0.00%> (ø)
...a/org/opensearch/security/util/AuthTokenUtils.java 62.50% <62.50%> (ø)

... and 19 files with indirect coverage changes

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions to clean up code.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Collaborator Author

Hi @DarshitChanpura, thanks for the feedbacks. I have applied those changes.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@DarshitChanpura DarshitChanpura added backport 2.x backport to 2.x branch v2.11.0 Issues targeting the 2.11 release labels Sep 29, 2023
@stephen-crawford
Copy link
Contributor

Should probably add unit tests but because of the timeline for the 2.11 release, we can make do with a fast follow-up in my opinion.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997 RyanL1997 merged commit 1ffa23c into opensearch-project:main Oct 2, 2023
57 of 58 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ffa23cc96a6bf96752c33b7f134e4e6139dc828
# Push it to GitHub
git push --set-upstream origin backport/backport-3419-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3419-to-2.x.

@RyanL1997
Copy link
Collaborator Author

Btw the unit tests has been added for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.11.0 Issues targeting the 2.11 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Set up a Util class for OBO Authenticator for key checks and endpoints checks
4 participants