-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Setup auth token utils for obo #3419
Conversation
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #3419 +/- ##
============================================
+ Coverage 64.23% 64.52% +0.28%
- Complexity 3490 3546 +56
============================================
Files 264 269 +5
Lines 20152 20363 +211
Branches 3363 3375 +12
============================================
+ Hits 12945 13139 +194
+ Misses 5530 5529 -1
- Partials 1677 1695 +18
|
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions to clean up code.
src/main/java/org/opensearch/security/securityconf/DynamicConfigModelV7.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/http/OnBehalfOfAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/authtoken/jwt/JwtVendor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/http/OnBehalfOfAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/authtoken/jwt/JwtVendor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Hi @DarshitChanpura, thanks for the feedbacks. I have applied those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Should probably add unit tests but because of the timeline for the 2.11 release, we can make do with a fast follow-up in my opinion. |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
d76ee00
Signed-off-by: Ryan Liang <jiallian@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ffa23cc96a6bf96752c33b7f134e4e6139dc828
# Push it to GitHub
git push --set-upstream origin backport/backport-3419-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Btw the unit tests has been added for this PR. |
Description
Setup auth token utils for obo
Enhancement, New feature
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.