[Backport 2.x] Feature OnBehalfOf Authentication #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997
changed the title
Codecov Report
@@ Coverage Diff @@
## 2.x #3563 +/- ##
============================================
+ Coverage 64.71% 64.86% +0.15%
- Complexity 3524 3598 +74
============================================
Files 274 281 +7
Lines 20044 20382 +338
Branches 3346 3374 +28
============================================
+ Hits 12971 13221 +250
- Misses 5406 5490 +84
- Partials 1667 1671 +4
|
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
stephen-crawford,
reta and
willyborankin
as code owners
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
cwperks
reviewed
Oct 19, 2023
src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
Show resolved
Hide resolved
cwperks
reviewed
Oct 19, 2023
src/main/java/org/opensearch/security/auth/BackendRegistry.java
Outdated
Show resolved
Hide resolved
willyborankin
previously approved these changes
Oct 19, 2023
DarshitChanpura
previously approved these changes
Oct 19, 2023
src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997
dismissed stale reviews from DarshitChanpura and willyborankin
via
94899b0
cwperks
reviewed
Oct 19, 2023
cwperks
approved these changes
Oct 19, 2023
This was referenced Oct 19, 2023
stephen-crawford
pushed a commit
that referenced
this pull request
Oct 24, 2023
…uth backend and add Privileged Action for `JwtParserBuilder ` (#3579) ### Description Switch to `supportsImpersonation` check for http auth backend + wrap JwtParserBuilder with `doPrivileged` Reference to @cwperks's [comment](#3563 (comment)): >As a default implementation the authDomain could have: > >``` >default boolean supportsImpersonation() { return true; } >``` > >and any authDomain that does not support it can override: > >``` >@OverRide >public boolean supportsImpersonation() { return false; } >``` * Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Enhancement ### Issues Resolved * Related #3563 Is this a backport? If so, please add backport PR # and/or commits # It has already been included in `2.x` ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Ryan Liang <jiallian@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport feature OnBehalfOf Authentication into
2.xbranchNew feature
Issues Resolved
For completely resolve the above issue, we still need to backport #3421 into
2.xbranch. However, since that change also includes something unrelated to OBO Auth, we will backport that separately.Testing
Unit Tests + Integration Tests included
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.