Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] provide spring AutoConfiguration support #34

Closed
Maglore opened this issue Oct 28, 2022 · 6 comments · Fixed by #56
Closed

[PROPOSAL] provide spring AutoConfiguration support #34

Maglore opened this issue Oct 28, 2022 · 6 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request

Comments

@Maglore
Copy link

Maglore commented Oct 28, 2022

What/Why

What are you proposing?

Provide an AutoConfiguration for spring opensearch library like it is done for elastisearch

What problems are you trying to solve?

Currently the RestClient has to be build from every user and every user has to define its own properties.
This can unified and simplified with this configuration.

What is the developer experience going to be?

This should ease the start of other spring developers with this library.

Are there any security considerations?

No, even if done correctly some basic security configurations can be made here.

@dblock
Copy link
Member

dblock commented Nov 1, 2022

Good idea. Care to contribute @Maglore?

@reta
Copy link
Collaborator

reta commented Nov 4, 2022

I have opened spring-projects/spring-boot#33011 so we could get Elasticsearch auto configuration out of our way (related issue is spring-projects/spring-boot#33010)

@dlvenable
Copy link
Member

Perhaps we should split this project into two modules:

  1. The core module. It would depend only on Spring Data.
  2. A Spring Boot starter with the auto configuration.

@reta
Copy link
Collaborator

reta commented Nov 5, 2022

+1 to have dedicated starter module, we also have an issue which I was trying to address in Spring Boot but it was rejected: we sadly have to find a way to exclude (may be using AutoConfigurationExcludeFilter or alike) the ElasticsearchDataAutoConfiguration since it needs the Elasticsearch Java Client no matter what.

@reta
Copy link
Collaborator

reta commented Nov 7, 2022

@Maglore if you are not working on it, I would like to pick it up so we should be ready for mid-November Spring / Spring Boot / Spring Data Elasticsearch releases, thanks!

@reta reta self-assigned this Nov 9, 2022
@reta reta added enhancement New feature or request and removed untriaged labels Nov 9, 2022
@Maglore
Copy link
Author

Maglore commented Nov 14, 2022

@reta, yes sry i have currently no time to work on it, sry for the late answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants