Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] index tag set to the EMRS job run is not correct #2908

Closed
ykmr1224 opened this issue Aug 6, 2024 · 3 comments
Closed

[BUG] index tag set to the EMRS job run is not correct #2908

ykmr1224 opened this issue Aug 6, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ykmr1224
Copy link
Collaborator

ykmr1224 commented Aug 6, 2024

What is the bug?
index tag set to the EMRS job run does not include datasource name and schema when those are not explicitly specified in the query.
Example query: CREATE MATERIALIZED VIEW mv1 AS ....
In this case, index tag should be flint_{datasourceName}_{schema}_mv1, but it is set to flint_mv1

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. start async-query with CREATE MATERIALIZED VIEW mv1 AS SELECT ...
  2. check EMR job run

What is the expected behavior?
index tag should look like flint_{datasourceName}_{schema}_mv1

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

@ykmr1224 ykmr1224 added bug Something isn't working untriaged labels Aug 6, 2024
@dai-chen dai-chen removed the untriaged label Aug 9, 2024
@dai-chen
Copy link
Collaborator

dai-chen commented Aug 9, 2024

Flint grammar allows this because we can infer the current catalog and database in Spark. Probably we should consider validating and disallowing this in SQL plugin.

@noCharger
Copy link
Contributor

Flint grammar allows this because we can infer the current catalog and database in Spark. Probably we should consider validating and disallowing this in SQL plugin.

+1, since Plugin doesn't have the catalog info exposure

@anirudha
Copy link
Collaborator

expectation is the use full qualified names for create including a DB name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants