Watch OpenSergo CRD actively in Istio environment #38
Conversation
123liuziming
force-pushed
the
feature/k8s-client
branch
from
68d711a
to
7cf4db8
Compare
|
Could you please illustrate the PR in the PR description? |
| func Init() error { | ||
| home, err := homeDir() | ||
| if err != nil { | ||
| log.Printf("Find empty home directory, %v", err) | ||
| return err | ||
| } | ||
| kubeConfig := filepath.Join(home, ".kube", "config") | ||
|
|
||
| // uses the current context get restConfig | ||
| config, err := clientcmd.BuildConfigFromFlags("", kubeConfig) | ||
| if err != nil { | ||
| log.Panic(err) | ||
| } | ||
| dynamicClient, err = dynamic.NewForConfig(config) | ||
| if err != nil { | ||
| log.Printf("Create dynamicClient for kubernetes failed %v", err) | ||
| return err | ||
| } | ||
| client, err = kubernetes.NewForConfig(config) | ||
| if err != nil { | ||
| log.Printf("Create client set for kubernetes failed %v", err) | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
what does this func used for? I guess it is used to check the kubeconfig when start in main.go? If that, the k8s_operator.go has done it . it will return error if could not find a kubeconfig when NewControlPlane() in main.go. So i think this func is unnecessary.
Just like following:
There was a problem hiding this comment.
OK, I will fix it
There was a problem hiding this comment.
em... Maybe first need to fix 👇 the following review comment, because I saw that the func Init() also Instance a dynamicClient which will used in ActiveCRDWatcher.
There was a problem hiding this comment.
If k8sclient in ActiveCRDWatcher can be replaced, the k8s_client.go can be deleted. If not, the instance func should be reserved.
| case TrafficRouterKind: | ||
| if crd != nil { | ||
| cls := crd.(*traffic.TrafficRouter) | ||
| _, err := k8sclient.ApplyCRD(ctx, cls.Namespace, cls.Name, transform.BuildUnstructuredVirtualService(cls), gvr.VirtualServiceGVR) |
There was a problem hiding this comment.
k8sclient is a client instanced in Init() of k8s_client.go which depended on k8s.io/client-go, and there is a client in CRDWatcher too, so maybe can try to replace k8sclient by the client in CRDWatcher.
This is only my opinion ~
There was a problem hiding this comment.
I will try to reuse the k8s-client in CRDWatcher! Thanks
Describe what this PR does / why we need it
The PR tends to watch OpenSergo TrafficRouter and VirtualWorkload actively in Istio Environment and convert them into VirtualService and DestinationRule in Istio.
Does this pull request fix one issue?
#37