feat: Add tls support on port 10248 #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
the
kind/feature
|
Could you please fix the lint check? |
jnan806
reviewed
Feb 28, 2023
|
I will fix these issues today. |
|
@123liuziming I have re-run the CI, but it looks was blocked. So can you force-push it again ~ |
|
It seems that the ci is okay |
|
@sczyh30 What do you think about this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #53
Support grpc tls on port 10248 simultaneously. Users can inject their PEM certificate and key on environment variable OPENSERGO_10248_CERT and OPENSERGO_10248_KEY. Port 10246 and port 10248 work together to provide both plantext and secure grpc service like what Istio 15010 and 15012 port does.