Add Makefile (#9) #22
Conversation
|
|
sczyh30
added
the
area/build-release
Makefile
Outdated
| @@ -0,0 +1,18 @@ | |||
| BIN_NAME=opensergo-control-plane | |||
There was a problem hiding this comment.
Could you please add the license header in the first line, like following:
# Copyright 2022, OpenSergo Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
|
Just found a more complete Makefile in the develop branch. Should we use this instead? |
|
That's OK ~ And there are some commands is not needed at this time in the Makefile of develop branch, You can ignore them by delete or comment. And also should verify the availability of commands you picked. |
|
I have reviewed both Makefiles. Most of the develop branch recipes perform tasks like usage help, code generation, docker resource management, as well as compiling go code. As this tasks are now executed by other tools I kept my branch's Makefile as simple as possible. |
|
em.... In the relation ISSUE, commands for |
Well, I sure can! But I need to acquire a more comprehensive view of the whole CI/CD process. I'll do my home work but, can you give some advice in this sense? |
|
the whole CI/CD process? the |
|
This Makefile is automatically generated by operator-sdk and only care about k8s operator aspects. |
|
@jnan806 , @sczyh30 I reached a point that k8s operator automatically generate its own Makefile, and grpc/protobuf needs another Makefile. In order accomodate both maybe the project folder structure should change. But I'm not in position to propose/foresee such changes. Are you willing to review this contribution? Or should I abandon it? |
The Makefile generated by operator-sdk is a template for universal project, not for all projects. Every project can modify it by self to adjust the actual demands in project. |
|
Now, typing protoc Download protoc locally if necessary.
|
|
@jnan806, Can you review my humble contribution? I would appreciate! 謝謝 |
Fixes #9