From 425129a700951b32d91411371c9048a425839eb7 Mon Sep 17 00:00:00 2001 From: Armel Soro Date: Tue, 27 Feb 2024 09:57:41 +0100 Subject: [PATCH] fix: increase default size of the dynamic-plugins-root volume from 1Gi to 2Gi This applies the same fix done in the Helm Chart [1]. As depicted in [2], the init container might fail with insufficient space error: ``` ======= Installing dynamic plugin ./dynamic-plugins/dist/backstage-plugin-scaffolder-backend-module-github-dynamic ==> Grabbing package archive through `npm pack` Traceback (most recent call last): File "/opt/app-root/src/install-dynamic-plugins.py", line 304, in main() File "/opt/app-root/src/install-dynamic-plugins.py", line 230, in main raise InstallException(f'Error while installing plugin \{ package } with \'npm pack\' : ' + completed.stderr.decode('utf-8')) __main__.InstallException: Error while installing plugin /opt/app-root/src/dynamic-plugins/dist/backstage-plugin-scaffolder-backend-module-github-dynamic with 'npm pack' : npm notice npm notice New major version of npm available! 9.8.1 -> 10.4.0 npm notice Changelog: npm notice Run `npm install -g npm@10.4.0` to update! npm notice npm ERR! code ENOSPC npm ERR! syscall open npm ERR! path /dynamic-plugins-root/backstage-plugin-scaffolder-backend-module-github-dynamic-0.2.0-next.3.tgz npm ERR! errno -28 npm ERR! nospc ENOSPC: no space left on device, open '/dynamic-plugins-root/backstage-plugin-scaffolder-backend-module-github-dynamic-0.2.0-next.3.tgz' npm ERR! nospc There appears to be insufficient space on your system to finish. npm ERR! nospc Clear up some disk space and try again. ``` [1] https://github.com/redhat-developer/rhdh-chart/pull/5 [2] https://issues.redhat.com/browse/RHIDP-1332 --- bundle/manifests/backstage-default-config_v1_configmap.yaml | 2 +- config/manager/default-config/deployment.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bundle/manifests/backstage-default-config_v1_configmap.yaml b/bundle/manifests/backstage-default-config_v1_configmap.yaml index 1c5bdbf1..f462e9fc 100644 --- a/bundle/manifests/backstage-default-config_v1_configmap.yaml +++ b/bundle/manifests/backstage-default-config_v1_configmap.yaml @@ -180,7 +180,7 @@ data: - ReadWriteOnce resources: requests: - storage: 1Gi + storage: 2Gi name: dynamic-plugins-root - name: dynamic-plugins-npmrc secret: diff --git a/config/manager/default-config/deployment.yaml b/config/manager/default-config/deployment.yaml index 30e495ff..fbe4b05d 100644 --- a/config/manager/default-config/deployment.yaml +++ b/config/manager/default-config/deployment.yaml @@ -21,7 +21,7 @@ spec: - ReadWriteOnce resources: requests: - storage: 1Gi + storage: 2Gi name: dynamic-plugins-root - name: dynamic-plugins-npmrc secret: