Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional command line tools for workshops #27

Open
utherp0 opened this issue Oct 31, 2019 · 3 comments
Open

Adding additional command line tools for workshops #27

utherp0 opened this issue Oct 31, 2019 · 3 comments

Comments

@utherp0
Copy link

utherp0 commented Oct 31, 2019

Would it be possible to add the following CLIs to the workshop image - this is for OCP4.2+ workshops:

odo
tkn (or whatever the Tekton CLI now is called)
kamel (for camel-k operator interactions)

@GrahamDumpleton
Copy link
Collaborator

This repository is only the spawner. The separate terminal image which the tools are installed in, and which the workshop dashboard image is derived from is:

It already includes odo as well as kubectl and oc.

As to tkn or other tools, the idea is that you would include what you need in the workshop image you created which derives from the dashboard image.

You can see how this is done in the existing tekton pipelines workshop in:

In other words, you build it in the workshop image which requires it.

Because there are too many such tools people may want and different workshops may feasibly need different versions of the tools to match the version the workshop is written for, it isn't practical to include them in the terminal base image.

@GrahamDumpleton
Copy link
Collaborator

Actually, should point out that where that build script installs tkn is actually wrong. It shouldn't be using its own .bin directory. Any binaries should be installed in /opt/app-root/bin. I will need to get that fixed.

@GrahamDumpleton
Copy link
Collaborator

Hmm, I actually already did raise the problem, but it still hasn't been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants