Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Language chosen only affects Gogs aspect of workshop #190

Open
benemon opened this issue Feb 9, 2021 · 3 comments
Open

Docs: Language chosen only affects Gogs aspect of workshop #190

benemon opened this issue Feb 9, 2021 · 3 comments

Comments

@benemon
Copy link

benemon commented Feb 9, 2021

Having recently run this, one comment was that it wasn't immediately obvious that running (for example) the node.js workshop would also require the user to pull down and spin up the Parksmap application - which is obviously a Spring Boot app.

User was briefly concerned that they'd selected the wrong workshop. Maybe add some wording to the Workshop Summary / Architecture Overview that highlights this?

@blues-man
Copy link
Contributor

Absolutely, thanks for your feedback. The idea was to just deploy a container image, which is language-agnostic, but under the hood it's a Spring boot app. Maybe some wording about it or a general purpose icon would help in this ambiguity.

@benemon
Copy link
Author

benemon commented Feb 9, 2021

Yes - and maybe in the Workshop Summary change:

Deploying an application from source code in a Git repository.

to:

Deploying a <chosen_framework> application from source code in a Git repository.

To keep some clarity around the role a user's chosen framework plays here.

@blues-man
Copy link
Contributor

I addressed this in this commit
96abc3a

for the second comment, I haven't yet since that requires a creation of multiple files just for this change, we'll keep in consideration.

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants