Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2i docs links are broken. #194

Open
pittar opened this issue Mar 4, 2021 · 3 comments
Open

s2i docs links are broken. #194

pittar opened this issue Mar 4, 2021 · 3 comments

Comments

@pittar
Copy link
Contributor

pittar commented Mar 4, 2021

There are links to the OpenShift documentation for s2i in two different modules. Both links are broken.

The 1st is in:
https://github.com/openshift-labs/starter-guides/blob/ocp-4.6/workshop/content/nationalparks-java.adoc
("OpenShift S2I documentation" link)

The 2nd is in:
https://github.com/openshift-labs/starter-guides/blob/ocp-4.6/workshop/content/mlbparks-binary-build.adoc
("official documentation" link)

@blues-man
Copy link
Contributor

Thanks @pittar ! Would you send a PR for that? Or I can fix it from your input, thanks for reporting it!

@pittar
Copy link
Contributor Author

pittar commented Mar 6, 2021

@blues-man Well... part of the problem is these sections don't seem to exist in 4.x docs.

For example, the 2nd link (binary builds) is in 3.11 docs, but doesn't seem to have a 4.x equivalent:
https://docs.openshift.com/container-platform/3.11/dev_guide/dev_tutorials/binary_builds.html

My best guess for the first link is this one:
https://docs.openshift.com/container-platform/4.7/cicd/builds/understanding-image-builds.html#builds-strategy-s2i-build_understanding-image-builds
but again... it's not really the same section as the old 3.11 docs.

I'd make a PR, but I'm not sure where you want the new links to actually go.

@blues-man
Copy link
Contributor

blues-man commented Mar 10, 2021

Hello @pittar, you are right. We also have to use 4.6 doc for this workshop, and I think you can use this link for S2I (nationalparks):
https://docs.openshift.com/container-platform/4.6/builds/build-strategies.html#builds-strategy-s2i-build_build-strategies
And this doc about binary builds (MLBParks):
https://docs.openshift.com/container-platform/4.6/builds/creating-build-inputs.html#builds-define-build-inputs_creating-build-inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants