From 55d9c4ad768f479073bb8c1a5feee904e1ac8e9c Mon Sep 17 00:00:00 2001 From: Michael Shen Date: Sat, 30 Mar 2024 11:04:15 -0400 Subject: [PATCH] Limit controller-runtime to v0.17.2 for Go 1.21 support Signed-off-by: Michael Shen --- config/build_image-v5.0.0.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/config/build_image-v5.0.0.sh b/config/build_image-v5.0.0.sh index 776bc46..f3a5616 100755 --- a/config/build_image-v5.0.0.sh +++ b/config/build_image-v5.0.0.sh @@ -27,8 +27,10 @@ go install sigs.k8s.io/kustomize/kustomize/${KUSTOMIZE_VERSION%%.*}@${KUSTOMIZE_ ################ # controller-gen ################ -CONTROLLER_GEN_VERSION="v0.14.0" -go install sigs.k8s.io/controller-tools/cmd/controller-gen@${CONTROLLER_GEN_VERSION} +# Latest is only compatible with Go 1.22 +# https://github.com/kubernetes-sigs/controller-runtime/issues/2744 +ENVTEST_VERSION="bf15e44028f908c790721fc8fe67c7bf2d06a611" +go install sigs.k8s.io/controller-tools/cmd/controller-gen@${ENVTEST_VERSION} ############# # openapi-gen @@ -39,8 +41,8 @@ go install k8s.io/code-generator/cmd/openapi-gen@${OPENAPI_GEN_VERSION} ######### # ENVTEST ######### -# We do not enforce versioning on setup-envtest -go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest +CONTROLLER_RUNTIME_VERSION="v0.17.2" +go install sigs.k8s.io/controller-runtime/tools/setup-envtest@${CONTROLLER_RUNTIME_VERSION} ############## # govulncheck