Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No validation of config in create ignition-configs #910

Closed
vrutkovs opened this issue Dec 14, 2018 · 2 comments
Closed

No validation of config in create ignition-configs #910

vrutkovs opened this issue Dec 14, 2018 · 2 comments

Comments

@vrutkovs
Copy link
Member

If the user brings in an incorrect install-config (e.g. metadata.name is empty or baseDomain is empty) and runs create ignition-configs the config is not validated. This would make bootstrap node breaks at some point, but this could be easily prevented by validating the configs first
@eparis
Copy link
Member

eparis commented Dec 14, 2018

@staebler

@staebler
Copy link
Contributor

This validation is included in #711.

@staebler staebler mentioned this issue Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vrutkovs @eparis @staebler