Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43453: permissions: add ec2:DescribeInstanceTypeOfferings req #9114

Merged
merged 1 commit into from
Nov 21, 2024
Merged

OCPBUGS-43453: permissions: add ec2:DescribeInstanceTypeOfferings req #9114

merged 1 commit into from
Nov 21, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Oct 18, 2024

The permission is required if the Installer has to derive the available zones.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-43453, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The permission is required if the Installer has to derive the available zones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 18, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-43453, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei October 18, 2024 13:51
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 18, 2024

I think we always sets zones in the install-config.yaml in our CI workflows, so this won't be tested by openshift/release#57897 + #8704

barbacbd
barbacbd reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@mtulio
Copy link
Contributor

mtulio commented Oct 18, 2024

FWIW: Looks like ci/prow/e2e-external-aws-ccm is in permanent failure. I am working on to provide fixes here openshift/release#57954

@mtulio
Copy link
Contributor

mtulio commented Oct 21, 2024

openshift/release#57954 merged. If you don't mind, please allow me to use your open PR to validate the fixes on presubmit e2e-external-aws-ccm previously failing. (rehearsals are failing for different reason, looking for more scenarios)

/test e2e-external-aws-ccm

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 24, 2024

/hold

for #8704

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 7, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 7, 2024

/test e2e-aws-ovn-min-perms

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 8, 2024

/hold

The min-perms job won't pass until #9106 merges.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 14, 2024

/label platform/aws

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2024
@r4f4
OCPBUGS-43453: permissions: add ec2:DescribeInstanceTypeOfferings req
e03ed9d 
The permission is required if the Installer has to derive the available
zones.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 18, 2024

Update: rebased on top of master to solve merge conflicts.

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 19, 2024

/test e2e-aws-ovn-min-perms

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024 •
edited
Loading

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous e03ed9d link false /test e2e-aws-ovn-heterogeneous
ci/prow/okd-scos-e2e-aws-ovn e03ed9d link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu
Copy link
Contributor

sadasu commented Nov 21, 2024

/test e2e-aws-ovn

@sadasu
Copy link
Contributor

sadasu commented Nov 21, 2024

/lgtm

e2e-aws-ovn-min-perms succeeded. @r4f4 is it time to remove the hold?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 21, 2024

e2e-aws-ovn-min-perms succeeded. @r4f4 is it time to remove the hold?

Definitely.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 21, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0ebb11c into openshift:master Nov 21, 2024
28 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@r4f4: Jira Issue OCPBUGS-43453: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43453 has been moved to the MODIFIED state.

In response to this:

The permission is required if the Installer has to derive the available zones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411211337.p0.g0ebb11c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202411211337.p0.g0ebb11c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.18.0-202411211337.p0.g0ebb11c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.18.0-202411211337.p0.g0ebb11c.assembly.stream.el9.
All builds following this will include this PR.

@r4f4 r4f4 mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@mtulio mtulio Awaiting requested review from mtulio

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@gpei gpei Awaiting requested review from gpei

Assignees

@sadasu sadasu

@barbacbd barbacbd

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@r4f4 @openshift-ci-robot @mtulio @patrickdillon @sadasu @openshift-bot @barbacbd @openshift-merge-robot