Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-2508: aws: remove unused autoscaling:DescribeAutoScalingGroups perm #9223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Nov 20, 2024

With the analysis from https://issues.redhat.com/browse/SPLAT-1844, the permission is required by the installer but never used.

With the analysis from https://issues.redhat.com/browse/SPLAT-1844, the
permission is required by the installer but never used.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2024

@r4f4: This pull request references CORS-2508 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

With the analysis from https://issues.redhat.com/browse/SPLAT-1844, the permission is required by the installer but never used.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 20, 2024

/label platform/aws

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 21, 2024

/retest

@sadasu
Copy link
Contributor

sadasu commented Nov 21, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@sadasu
Copy link
Contributor

sadasu commented Nov 27, 2024

/retest

Retesting both the CIs that test AWS edge instances.

@sadasu
Copy link
Contributor

sadasu commented Nov 27, 2024

/retest

Retesting both the CIs that test AWS edge instances.

I see that these failures are being worked on in different bugs.

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 63ea6b3 link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-edge-zones 63ea6b3 link false /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. platform/aws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants