Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-21841: CRI-O: Use 127.0.0.1 for stream server with random port #3984

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[release-4.14] OCPBUGS-21841: CRI-O: Use 127.0.0.1 for stream server with random port #3984

merged 1 commit into from
Oct 18, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3853

/assign kwilczynski

@saschagrunert
CRI-O: Use 127.0.0.1 for stream server with random port
a8aa428 
This should work since it's the default in CRI-O with the merge of
cri-o/cri-o#1714. It slightly increases security
of the default configuration.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 17, 2023
Merged
@openshift-ci openshift-ci bot requested review from mtrmac and umohnani8 October 17, 2023 01:46
@kwilczynski
Copy link
Member

/approve

@kwilczynski
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@kwilczynski
Copy link
Member

Hello @sinnykumari, sorry to bother you, but I was wondering if you could provide your approvals here too, since you approved the original Pull Request. This is a backport against 4.14, as we need it there too.

Thank you in advance!

@saschagrunert
Copy link
Member

/retest

@kwilczynski
Copy link
Member

/test e2e-gcp-rt-op

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-rt-op a8aa428 link false /test e2e-gcp-rt-op
ci/prow/okd-scos-e2e-gcp-op a8aa428 link false /test okd-scos-e2e-gcp-op
ci/prow/e2e-aws-ovn-fips-op a8aa428 link false /test e2e-aws-ovn-fips-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuqi-zhang
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, openshift-cherrypick-robot, saschagrunert, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@wking
Copy link
Member

wking commented Oct 17, 2023

Hmm, maybe it's /retitle?

/retitle OCPBUGS-20410: CRI-O: Use 127.0.0.1 for stream server with random port

@openshift-ci openshift-ci bot changed the title [release-4.14] CRI-O: Use 127.0.0.1 for stream server with random port OCPBUGS-20410: CRI-O: Use 127.0.0.1 for stream server with random port Oct 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 17, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-20410, which is invalid:

  • expected Jira Issue OCPBUGS-20410 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3853

/assign kwilczynski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title OCPBUGS-20410: CRI-O: Use 127.0.0.1 for stream server with random port [release-4.14] OCPBUGS-20410: CRI-O: Use 127.0.0.1 for stream server with random port Oct 17, 2023
@wking
Copy link
Member

wking commented Oct 17, 2023

#3853 is using OCPBUGS-20410 for 4.15. I've cloned OCPBUGS-21841 for this 4.14 backport.

/retitle OCPBUGS-21841: CRI-O: Use 127.0.0.1 for stream server with random port

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-20410: CRI-O: Use 127.0.0.1 for stream server with random port OCPBUGS-21841: CRI-O: Use 127.0.0.1 for stream server with random port Oct 17, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21841, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20410 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3853

/assign kwilczynski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Oct 17, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 17, 2023
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-21841, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20410 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-20410 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr October 17, 2023 20:13
@openshift-ci openshift-ci bot changed the title OCPBUGS-21841: CRI-O: Use 127.0.0.1 for stream server with random port [release-4.14] OCPBUGS-21841: CRI-O: Use 127.0.0.1 for stream server with random port Oct 17, 2023
@sinnykumari
Copy link
Contributor

For cherry-pick approval
/assign @sunilcio

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@sinnykumari: GitHub didn't allow me to assign the following users: sunilcio.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

For cherry-pick approval
/assign @sunilcio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunilcio
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 18, 2023
@openshift-ci openshift-ci bot merged commit 594da89 into openshift:release-4.14 Oct 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21841: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21841 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3853

/assign kwilczynski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mtrmac mtrmac Awaiting requested review from mtrmac

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@kwilczynski kwilczynski

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.