-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Add PersesURL feature flag to pass in url for Perses Dashboards #266
base: main
Are you sure you want to change the base?
Conversation
GET /api/v1/projects/<project_name>/dasbhoards/<dasbhoard_name> GET /api/v1/projects/<project_name>/dasbhoards
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/proxy/proxy.go
Outdated
) | ||
|
||
type ProxyPort int | ||
|
||
const ( | ||
AlertmanagerPort ProxyPort = 9444 | ||
ThanosQuerierPort ProxyPort = 9445 | ||
PersesPort ProxyPort = 9446 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update the port argument info in plugin-backend to include this port as reserved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove the proxy so the CR can handle it.
@zhuje: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
As discussed in the tech sync, I don't think we need the proxy here as this will be handled by the proxy created in the ConsolePlugin CR |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Related Issue:
https://issues.redhat.com/browse/OU-432
Steps
COO (monitoring-console-plugin)
CMO (monitoring-plugin)
Perses API for Dashboards
https://perses.dev/perses/docs/api/dashboard/
Get a Single Perses Dashboard
GET /api/v1/projects/<project_name>/dasbhoards/<dasbhoard_name>
Get List of all Perses Dashboards
GET /api/v1/projects/<project_name>/dasbhoards