Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add PersesURL feature flag to pass in url for Perses Dashboards #266

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhuje
Copy link
Contributor

@zhuje zhuje commented Nov 21, 2024

Related Issue:

https://issues.redhat.com/browse/OU-432

Steps

COO (monitoring-console-plugin)

  • Add the Perses dashboards feature called "perses-dashboards" in the monitoring plugin.
  • Allow the plugin to receive a flag with the Perses URL
  • [-] Create a function to fetch dashboards from the Perses API

CMO (monitoring-plugin)

  • [] An extension point is added to inject the function to fetch dashboards from Perses API and merge the results with the current console dashboards

Perses API for Dashboards

https://perses.dev/perses/docs/api/dashboard/
Get a Single Perses Dashboard
GET /api/v1/projects/<project_name>/dasbhoards/<dasbhoard_name>
Get List of all Perses Dashboards
GET /api/v1/projects/<project_name>/dasbhoards

GET /api/v1/projects/<project_name>/dasbhoards/<dasbhoard_name>
GET /api/v1/projects/<project_name>/dasbhoards
@zhuje zhuje marked this pull request as draft November 21, 2024 15:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
)

type ProxyPort int

const (
AlertmanagerPort ProxyPort = 9444
ThanosQuerierPort ProxyPort = 9445
PersesPort ProxyPort = 9446
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the port argument info in plugin-backend to include this port as reserved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the proxy so the CR can handle it.

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@zhuje: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 660d619 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

As discussed in the tech sync, I don't think we need the proxy here as this will be handled by the proxy created in the ConsolePlugin CR

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants