[must-gather] Refactor points

[mateusoliveira43]

@mpryc suggestions in #1269 for refactoring of must-gather tool

• change /usr/bin/oc to oc
• do some check if the expected cluster that is passed here is valid, but at least checking if variable is set

  oadp-operator/must-gather/collection-scripts/gather_crs

  Line 6 in 9ed5b89

  clusterID=$1

• capital letters for variable names in shell

  oadp-operator/must-gather/collection-scripts/gather_crs

  Line 3 in 9ed5b89

  max_parallelism=10

Ideally, we should rewrite bash code in Go.

[mateusoliveira43]

Also add shellcheck validation (example docker run --rm -v "$PWD:/mnt" koalaman/shellcheck:stable must-gather/collection-scripts/<file-name>) if still following with shell script.

Ideally, must-gather should be a separate repository.

[kaovilai]

also add tests to e2e and assert velero CRDs collected matches what should be in bundle etc.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[kaovilai]

/remove-lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale