Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate BSL/VSL in E2E tests #1288

Closed
mateusoliveira43 opened this issue Jan 27, 2024 · 2 comments · Fixed by #1463
Closed

Validate BSL/VSL in E2E tests #1288

mateusoliveira43 opened this issue Jan 27, 2024 · 2 comments · Fixed by #1463
Labels
CI lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@mateusoliveira43
Copy link
Contributor

Today, azure and gcp create non default secrets and do not add that info to SnapshotLocations in DPA, but nevertheless, this test do not break

Entry("DPA CR with bsl and vsl", InstallCase{

We should validate BSL/VSL in our tests

For consistency, SnapshotLocations build code should be updated to have similar logic to BackupLocations one

SnapshotLocations: v.CustomResource.Spec.SnapshotLocations,

Credential: &corev1.SecretKeySelector{
LocalObjectReference: corev1.LocalObjectReference{
Name: "bsl-cloud-credentials-" + v.Provider,
},
Key: "cloud",
},

Also, this option should be removed also for consistency, as developer can not select BSL secret name for e2e run

flag.StringVar(&credSecretRef, "creds_secret_ref", "cloud-credentials", "Credential secret ref (name) for volume storage location")

@weshayutin weshayutin added this to the 1.4.0 milestone Jan 29, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2024
@mateusoliveira43
Copy link
Contributor Author

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants