Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize time fields from DPA when API version updates #1295

Open
mateusoliveira43 opened this issue Jan 31, 2024 · 3 comments
Open

Standardize time fields from DPA when API version updates #1295

mateusoliveira43 opened this issue Jan 31, 2024 · 3 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mateusoliveira43
Copy link
Contributor

There are several time fields in DPA, some being

  • spec.configuration.velero.args.backup-sync-period
  • spec.configuration.velero.args.default-backup-ttl
  • spec.configuration.velero.args.default-item-operation-timeout
  • spec.configuration.velero.args.default-repo-maintain-frequency
  • spec.configuration.velero.args.fs-backup-timeout
  • spec.configuration.velero.args.garbage-collection-frequency
  • spec.configuration.velero.args.item-operation-sync-frequency
  • spec.configuration.velero.args.resource-timeout
  • spec.configuration.velero.args.store-validation-frequency
  • spec.configuration.velero.args.terminating-resource-timeout
  • spec.configuration.nodeAgent.timeout
  • spec.backupLocations[].velero.backupSyncPeriod
  • spec.configuration.velero.defaultItemOperationTimeout
  • spec.configuration.velero.resourceTimeout

And they are typed as string, metav1.Duration and time.Duration.

They should be all be the same type, for improved user and developer experience. They should also be validated in validators.

@weshayutin
Copy link
Contributor

well also cross reference with the value expected from velero I think

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2024
@kaovilai
Copy link
Member

kaovilai commented May 1, 2024

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants