Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI check go dependencies #1374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: CI check go dependencies #1374

wants to merge 1 commit into from

Conversation

mateusoliveira43
Copy link
Contributor

Why the changes were made

Fixes #1369

How the changes were made

Created make command that will check if go mod tidy and go mod verify were run.

How to test the changes made

Test new command, running make check-go-dependencies or make test

@mateusoliveira43
fix: CI check go dependencies
9f92c9a 
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@mateusoliveira43
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mateusoliveira43]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mateusoliveira43
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 19, 2024

@mateusoliveira43: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-e2e-test-aws 9f92c9a link true /test 4.16-e2e-test-aws
ci/prow/4.15-images 9f92c9a link true /test 4.15-images
ci/prow/4.15-e2e-test-kubevirt-aws 9f92c9a link true /test 4.15-e2e-test-kubevirt-aws
ci/prow/4.15-ci-index 9f92c9a link true /test 4.15-ci-index
ci/prow/4.15-e2e-test-aws 9f92c9a link true /test 4.15-e2e-test-aws
ci/prow/4.16-ci-index 9f92c9a link true /test 4.16-ci-index
ci/prow/4.16-e2e-test-kubevirt-aws 9f92c9a link true /test 4.16-e2e-test-kubevirt-aws
ci/prow/4.16-images 9f92c9a link true /test 4.16-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

@mrnold mrnold Awaiting requested review from mrnold

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. CI do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add go mod tidy verify job to CI
3 participants
@mateusoliveira43 @openshift-merge-robot @kaovilai