-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncap kubernetes version #289
Comments
so I think the reason we pinned the version in the past is that there were breaking changes that affected our client and broke a few projects, and since the API was only guaranteed at a major version level we wanted to make sure we didn't have random breakages again when a new release came out. That being said we should definitely get the 0.9.0 release (which is pinned to 9.x) out the door so that we at least have a version out that supports every release of the kubernetes client. If there's a cleverer way to solve this I'd be happy to hear it but I think if we just remove the version constraints it might end up causing more pain than it saves. |
Ya, I'm not sure the state of your testing, but would adding tox jobs for each kubernetes version (and one uncapped) work for coverage? I see 10.0.0a1 on pypi as of April 4th, so that's coming soon too. |
looks like urllib3 is being blocked by openshift as well
|
I think we'll continue manually updating to track the kubernetes-client version, as breaking changes remain a concern (ie, kubernetes-client/python#974) |
I think we removed the dep on openshift so we don't have this problem anymore. |
At the moment openshift-restclient-python is the only package requiring a specific version of the kubernetes python library. This causes co-installability issues. This blocks others from using new versions of kubernetes until you update/release. At that point they'd have to switch to the new version as you only support one version at a time.
http://logs.openstack.org/04/657204/3/check/requirements-tox-py27-check-uc/0d243cf/job-output.txt.gz#_2019-05-07_14_43_24_123381
specifically the following line
Would it be possible to uncap the version of kubernetes you support. If you want to limit the version in your installs that is what constraints are for, see the following for an example.
https://github.com/openstack/requirements/blob/16e8fd6a0f179e3cad0ae2197a5c1be18ada2ea1/upper-constraints.txt#L427
https://github.com/openstack/requirements/blob/16e8fd6a0f179e3cad0ae2197a5c1be18ada2ea1/tox.ini#L19
if 1.3.0 comes out for foo (see below) the following would happen.
The text was updated successfully, but these errors were encountered: