From d8ec8f4051fc6ccb78c423b32709d09f01495a5c Mon Sep 17 00:00:00 2001
From: Robb Hamilton <rhamilto@redhat.com>
Date: Thu, 5 Oct 2017 15:49:09 -0400
Subject: [PATCH] Fixes unnecessary scrollbar when there's a quota status alert
 and...

* Fixes inconsistent spacing on h1
* Fixes unnecessary scrollbar on Limit Range tables

Fixes #2213
---
 app/views/quota.html      | 14 ++++----------
 dist/scripts/templates.js | 14 ++++----------
 2 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/app/views/quota.html b/app/views/quota.html
index 1339e8d03f..937ae2fad5 100644
--- a/app/views/quota.html
+++ b/app/views/quota.html
@@ -1,9 +1,7 @@
 <div class="middle">
   <div class="middle-content">
-    <div class="container-fluid mar-top-xl">
+    <div class="container-fluid">
       <alerts alerts="alerts"></alerts>
-      <div class="row">
-        <div class="col-md-12">
           <h1>
             <span ng-if="clusterQuotas.length">Cluster </span>Quota
             <span class="page-header-link">
@@ -68,7 +66,7 @@ <h3 class="text-center">Memory <small>Limit</small></h3>
                 </thead>
                 <tbody>
                   <tr ng-if='!quota.status.total.used' class="danger">
-                    <td colspan="5">
+                    <td colspan="4">
                       <span data-toggle="tooltip" title="Missing quota status" class="pficon pficon-error-circle-o" style="cursor: help;"></span>
                       Status has not been reported on this quota usage record.  Any resources limited by this quota record can not be allocated.
                     </td>
@@ -159,7 +157,7 @@ <h3 class="text-center">Memory <small>Limit</small></h3>
                 </thead>
                 <tbody>
                   <tr ng-if='!quota.status.used' class="danger">
-                    <td colspan="5">
+                    <td colspan="3">
                       <span data-toggle="tooltip" title="Missing quota status" class="pficon pficon-error-circle-o" style="cursor: help;"></span>
                       Status has not been reported on this quota usage record.  Any resources limited by this quota record can not be allocated.
                     </td>
@@ -243,8 +241,7 @@ <h2 ng-if="limitRanges.length">{{limitRange.metadata.name}}</h2>
                       </span>
                     </th>
                   </thead>
-                  <tbody>
-                    <tr ng-repeat-start="limit in limitRange.spec.limits"></tr>
+                  <tbody ng-repeat="limit in limitRange.spec.limits">
                     <tr ng-repeat="(type, typeLimits) in limitsByType[limitRange.metadata.name][limit.type]">
                       <td>{{limit.type}} {{type | computeResourceLabel : true}}</td>
                       <td>{{(typeLimits.min | usageWithUnits : type) || "&mdash;"}}</td>
@@ -253,14 +250,11 @@ <h2 ng-if="limitRanges.length">{{limitRange.metadata.name}}</h2>
                       <td>{{(typeLimits["default"] | usageWithUnits : type) || "&mdash;"}}</td>
                       <td>{{typeLimits.maxLimitRequestRatio || "&mdash;"}}</td>
                     </tr>
-                    <tr ng-repeat-end></tr>
                   </tbody>
                 </table>
               </div>
             </div>
           </div>
-        </div><!-- /col-* -->
-      </div>
     </div>
   </div><!-- /middle-content -->
 </div>
diff --git a/dist/scripts/templates.js b/dist/scripts/templates.js
index aaf15ee230..a01d2a98b1 100644
--- a/dist/scripts/templates.js
+++ b/dist/scripts/templates.js
@@ -12792,10 +12792,8 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
   $templateCache.put('views/quota.html',
     "<div class=\"middle\">\n" +
     "<div class=\"middle-content\">\n" +
-    "<div class=\"container-fluid mar-top-xl\">\n" +
+    "<div class=\"container-fluid\">\n" +
     "<alerts alerts=\"alerts\"></alerts>\n" +
-    "<div class=\"row\">\n" +
-    "<div class=\"col-md-12\">\n" +
     "<h1>\n" +
     "<span ng-if=\"clusterQuotas.length\">Cluster </span>Quota\n" +
     "<span class=\"page-header-link\">\n" +
@@ -12858,7 +12856,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</thead>\n" +
     "<tbody>\n" +
     "<tr ng-if=\"!quota.status.total.used\" class=\"danger\">\n" +
-    "<td colspan=\"5\">\n" +
+    "<td colspan=\"4\">\n" +
     "<span data-toggle=\"tooltip\" title=\"Missing quota status\" class=\"pficon pficon-error-circle-o\" style=\"cursor: help\"></span>\n" +
     "Status has not been reported on this quota usage record. Any resources limited by this quota record can not be allocated.\n" +
     "</td>\n" +
@@ -12940,7 +12938,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</thead>\n" +
     "<tbody>\n" +
     "<tr ng-if=\"!quota.status.used\" class=\"danger\">\n" +
-    "<td colspan=\"5\">\n" +
+    "<td colspan=\"3\">\n" +
     "<span data-toggle=\"tooltip\" title=\"Missing quota status\" class=\"pficon pficon-error-circle-o\" style=\"cursor: help\"></span>\n" +
     "Status has not been reported on this quota usage record. Any resources limited by this quota record can not be allocated.\n" +
     "</td>\n" +
@@ -13015,8 +13013,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</span>\n" +
     "</th>\n" +
     "</thead>\n" +
-    "<tbody>\n" +
-    "<tr ng-repeat-start=\"limit in limitRange.spec.limits\"></tr>\n" +
+    "<tbody ng-repeat=\"limit in limitRange.spec.limits\">\n" +
     "<tr ng-repeat=\"(type, typeLimits) in limitsByType[limitRange.metadata.name][limit.type]\">\n" +
     "<td>{{limit.type}} {{type | computeResourceLabel : true}}</td>\n" +
     "<td>{{(typeLimits.min | usageWithUnits : type) || \"&mdash;\"}}</td>\n" +
@@ -13025,7 +13022,6 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<td>{{(typeLimits[\"default\"] | usageWithUnits : type) || \"&mdash;\"}}</td>\n" +
     "<td>{{typeLimits.maxLimitRequestRatio || \"&mdash;\"}}</td>\n" +
     "</tr>\n" +
-    "<tr ng-repeat-end></tr>\n" +
     "</tbody>\n" +
     "</table>\n" +
     "</div>\n" +
@@ -13033,8 +13029,6 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "</div>\n" +
     "</div>\n" +
-    "</div>\n" +
-    "</div>\n" +
     "</div>"
   );