Entire notification drawer flashes on update

[spadgett]

@jeff-phillips-18 @benjaminapetersen We should look at adding a track by for event UID if possible (and add UIDs to other toasts when we add them to the drawer). Right now the entire drawer contents flashes because we haven't gotten track by right.

[spadgett]

Probably requires upstream angular-patternfly changes.

[spadgett]

[spadgett]

@benjaminapetersen Per our conversation, let's remove any CSS animations until we can get track by working upstream.

[jeff-phillips-18]

@spadgett Do you think using track by $index will not help this issue?

[spadgett]

@jeff-phillips-18 I don't think so because the index in the array for a particular event changes when items are added and removed.

Edit: Or reordered like below.

[spadgett]

Part of the problem is that the same event appears twice momentarily in the drawer.

Video:

Here's a frame from the video with the same item in the drawer twice:

[spadgett]

Yeah I think it is because of a missing or bad track by. The item moves from the bottom of the list to the top, but AngularJS doesn't know that it's really the same item so you have the remove animation.