Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to handle parameters display when a user cannot view secrets #2317

Closed
jeff-phillips-18 opened this issue Oct 19, 2017 · 2 comments
Closed

Need to handle parameters display when a user cannot view secrets #2317

jeff-phillips-18 opened this issue Oct 19, 2017 · 2 comments
Assignees
@jeff-phillips-18
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3
Milestone
3.7.0

Comments

@jeff-phillips-18
Copy link
Member

Currently any parameters from secrets are not shown at all if the user does not have permission to view secrets. We should indicate that the parameters exist but not reveal the values.

Follow on from #2237
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Oct 19, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 19, 2017
@jeff-phillips-18
Copy link
Member Author

Conversation from #2337
spadgett:

We could possibly fill in the redacted values using status.externalProperties.parameters when users can't list secrets (without letting them reveal). I'm OK handling this as a follow on, however.

jeff-phillips-18:

What should we do when the user does reveal and we have redacted values for some of the parameters? Continue to show ***** for those parameters?

spadgett:

Maybe remove the "reveal" action?

@spadgett spadgett mentioned this issue Oct 20, 2017
Closed
@jeff-phillips-18
Copy link
Member Author

Fixed by #2355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@spadgett @jeff-phillips-18