From 4aa9a1cf677f1f35843fe8eb6329a40df75b919b Mon Sep 17 00:00:00 2001 From: Samuel Padgett Date: Fri, 6 Oct 2017 15:31:17 -0400 Subject: [PATCH] Fix bug deleting bindings for service instance The logic checking if the binding was already deleted was flipped. --- app/scripts/services/serviceInstances.js | 2 +- dist/scripts/scripts.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/scripts/services/serviceInstances.js b/app/scripts/services/serviceInstances.js index 767315f970..b9a6f30de8 100644 --- a/app/scripts/services/serviceInstances.js +++ b/app/scripts/services/serviceInstances.js @@ -60,7 +60,7 @@ angular.module("openshiftConsole") var resource = APIService.getPreferredVersion('serviceinstancecredentials'); getBindingsIfNecessary(apiObject, bindings).then(function(serviceBindings) { _.each(serviceBindings, function (binding) { - if (!binding.metadata.deletionTimestamp) { + if (binding.metadata.deletionTimestamp) { return; } diff --git a/dist/scripts/scripts.js b/dist/scripts/scripts.js index f7b4f2da69..4337583d6a 100644 --- a/dist/scripts/scripts.js +++ b/dist/scripts/scripts.js @@ -4315,7 +4315,7 @@ namespace: t.metadata.namespace }, u = a.getPreferredVersion("serviceinstancecredentials"); l(t, n).then(function(t) { _.each(t, function(t) { -t.metadata.deletionTimestamp && i.delete(u, t.metadata.name, r).then(function() { +t.metadata.deletionTimestamp || i.delete(u, t.metadata.name, r).then(function() { c.addNotification({ type: "success", message: "Binding " + t.metadata.name + "' was marked for deletion."