Properly support git uris of the form user@host:path/to/file.git in build secret injector

[jim-minter]

It's confusing that you currently /must/ run oc annotate secrets/foo 'build.openshift.io/source-secret-match-uri-1=ssh://host/path/to/file.git' (with ssh://, without user@) but then may run oc new-app user@host:path/to/file.git (without ssh://, with user@) or oc new-app ssh://user@host/path/to/file.git (with ssh://, with user@).

@mvlach

[jim-minter]

(note to self: saw 'Host key verification failed' error at build time after successful secret injection - may or may not have been down to host infrastructure).

[mvlach]

I think there is problem with the ssh:// pattern. I created new secret with my private credentials (ssh) and created the new-app. Then manually add secret and everythink build correctly.

Let's assume that I have correct secret annotated

build.openshift.io/source-secret-match-uri-1=ssh://host:path/to.git

and when I create a new application like this

oc new-app wildfly~git@host:path/to.git

then the build doesn't work. The spec.source.sourceSecret.name is not correclty enabled.
It is very confusing.

---

The correct form is:

oc annotate secrets/sshsecret 'build.openshift.io/source-secret-match-uri-1=ssh://host/path/to.git'

and

oc new-app wildfly~ssh://git@host/path/to.git

when you use new-app without ssh:// then the sourceName is not set and if you use : instead of / then the git source cannot be pulled.

@jim-minter

[jim-minter]

Some improvements in #13282

[jim-minter]

Documentation improvements in openshift/openshift-docs#5232