Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse config change triggers into the main DC controller #13763

Closed
0xmichalis opened this issue Apr 13, 2017 · 5 comments
Closed

Collapse config change triggers into the main DC controller #13763

0xmichalis opened this issue Apr 13, 2017 · 5 comments

Comments

@0xmichalis
Copy link
Contributor

Once #13242 is merged, we can move the CCT mechanism from the deployment trigger controller into the main DC controller and switch the former controller off.

@0xmichalis
Copy link
Contributor Author

The blue peak is 400s from instantiate as per @smarterclayton. Those are coming from the deployment trigger controller most likely (what else). This issue should fix that peak so I am adding this to the 3.7 milestone.
unnamed

@0xmichalis
Copy link
Contributor Author

0xmichalis commented Jun 11, 2017

Those are API server errors during the 3.5->3.6 upgrade of devpreview btw

@0xmichalis
Copy link
Contributor Author

@mfojtik this is the issue I mentioned today. 400s by instantiate is the #1 error coming from our API server. Collapsing the deployment trigger controlller in the main controller, ought to fix it since we will stop using instantiate in the controller.

@mfojtik
Copy link
Contributor

mfojtik commented Jun 21, 2017

+1 we have to fix this, on my 3.7 list

@0xmichalis
Copy link
Contributor Author

Fixed by #14910 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants