Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable portworx #15269

Closed
deads2k opened this issue Jul 18, 2017 · 8 comments
Closed

re-enable portworx #15269

deads2k opened this issue Jul 18, 2017 · 8 comments

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2017

The rebase had to disable portworx because of a double proto registration. See UPSTREAM: <drop>: hack out portworx to avoid double proto registration in the rebase branch here #15234.

That pull is reviewed and green, so its a good base for starting over. If you revert the UPSTREAM patch, you'll see error messages about duplicate registrations.

@harsh-px
Copy link

@deads2k Can we please get this back?

As a result of this, people using Openshift 3.6 are not able to use Portworx.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 17, 2017

As a result of this, people using Openshift 3.6 are not able to use Portworx.

This is known in 3.7 (happened during the rebase). If it's broken in 3.6, then that's a separate and unknown problem.

@derekwaynecarr @rootfs

@rootfs
Copy link
Member

rootfs commented Aug 17, 2017

@deads2k portworx volume should work, but provisioner is not enabled (missing in here)

@harsh-px refer to #15661

@harsh-px
Copy link

@rootfs Thanks for the info. If we submit a PR now to enable the provisioner, can this make it to any 3.6 patch release?

@adityadani
Copy link
Contributor

PR #15862 got merged.
What is the procedure to cherry-pick changes into release-3.6 branch? We would like to enable portworx for the upcoming 3.6.x release.

@adityadani
Copy link
Contributor

@deads2k What is the procedure to cherry-pick changes from master to a release branch?

@liggitt
Copy link
Contributor

liggitt commented Sep 14, 2017

it was disabled only in the 3.7 branch as part of the rebase onto 1.7

@liggitt liggitt closed this as completed Sep 14, 2017
@adityadani
Copy link
Contributor

@liggitt. This PR #15862 solves two issues

  1. solves the protobuf conflict because of which portworx was disabled (code commented out) in rebase 1.7 branch
  2. Enables the portworx plugin in openshift. (adds portworx to the list of plugins in openshift)
    AFAIK we will need to enable portworx just like other plugins Enable Scaleio volume #15661.
    But we wanted to do it the one of the 3.6.x releases as well. Is it possible to do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants