Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: faq: clean up dynamic secondary device example #1509

Merged
merged 1 commit into from
May 21, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented May 16, 2024

We don't need to use an overcomplicated env unit dropin here. We can just label the filesystem with a stable name and use that to refer to the device in the mount unit.

Related: coreos/fedora-coreos-tracker#1732

We don't need to use an overcomplicated env unit dropin here. We can
just label the filesystem with a stable name and use that to refer to
the device in the mount unit.

Related: coreos/fedora-coreos-tracker#1732
@openshift-ci openshift-ci bot requested review from lukewarmtemp and prestist May 16, 2024 18:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@travier
Copy link
Member

travier commented May 21, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram, jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jbtrystram,jlebon,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@jlebon
Copy link
Member Author

jlebon commented May 21, 2024

/refresh

@jlebon jlebon changed the title faq: clean up dynamic secondary device example NO-JIRA: faq: clean up dynamic secondary device example May 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

We don't need to use an overcomplicated env unit dropin here. We can just label the filesystem with a stable name and use that to refer to the device in the mount unit.

Related: coreos/fedora-coreos-tracker#1732

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 353d297 into openshift:master May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants