Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-load-balancer, external-dns: move image building to the repository [redo] #55189

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Aug 5, 2024

Revert the changes made in #52589 for aws-load-balancer-controller and external-dns. We want to keep the configs for them as they were in #46164.

@openshift-ci openshift-ci bot requested review from Miciah and miheer August 5, 2024 11:13
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@alebedev87: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-aws-load-balancer-controller-openshift-rel-1.0-images openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-openshift-rel-1.0-unit openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-main-images openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-main-unit openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-openshift-release-0.2-images openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-openshift-release-0.2-unit openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-openshift-rel-1.1-images openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-openshift-rel-1.1-unit openshift/aws-load-balancer-controller presubmit Ci-operator config changed
pull-ci-openshift-external-dns-release-1.1-images openshift/external-dns presubmit Ci-operator config changed
pull-ci-openshift-external-dns-release-1.1-unit openshift/external-dns presubmit Ci-operator config changed
pull-ci-openshift-external-dns-master-images openshift/external-dns presubmit Ci-operator config changed
pull-ci-openshift-external-dns-master-unit openshift/external-dns presubmit Ci-operator config changed
pull-ci-openshift-external-dns-release-1.2-images openshift/external-dns presubmit Ci-operator config changed
pull-ci-openshift-external-dns-release-1.2-unit openshift/external-dns presubmit Ci-operator config changed
pull-ci-openshift-external-dns-release-1.0-images openshift/external-dns presubmit Ci-operator config changed
pull-ci-openshift-external-dns-release-1.0-unit openshift/external-dns presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@alebedev87
Copy link
Contributor Author

/pj-rehearse ack

No tests as it's a re-add of #46164.

@openshift-ci-robot
Copy link
Contributor

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 5, 2024
@miheer
Copy link

miheer commented Aug 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2024
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, miheer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6e86b03 into openshift:master Aug 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants